Fiddle: Spacing issues with <code> tags in tour

[kerolloz]

this should be calls BrowserWindow

[kerolloz]

I also found this

[kerolloz]

After inspecting the source code, I believe this is an issue with <code> tags.

[kerolloz]

more info...
OS: Linux, Ubuntu 19.04.
Fiddle Versison: v0.9.0

[malept]

Seems like https://github.com/electron/fiddle/pull/216 didn't fix it?

[erickzhao]

I think #216 didn't work here because the HTML parser does not detect spaces at the beginning of the line as a whitespace character. If it did, indenting would be hard (each line actually has like 12 spaces in front of it 😅).

This does not work:

<p>
  Every Electron app starts with a main script, very similar to how
  a Node.js application is started. The main script runs in the "main
  process". To display a user interface, the main process creates renderer
  processes – usually in the form of windows, which Electron calls 
   <code>BrowserWindow</code>.
</p>

but this should:

<p>
  Every Electron app starts with a main script, very similar to how
  a Node.js application is started. The main script runs in the "main
  process". To display a user interface, the main process creates renderer
  processes – usually in the form of windows, which Electron
  calls <code>BrowserWindow</code>.
</p>

@kerolloz if you'd like to take this up, this should be an easy problem to fix!

[malept]

There's also the classic/old-school "use  " solution.

[kerolloz]

@erickzhao

Okay, I'll fix it

[arnitkun]

I have a pull request ready but am unable to push my fix.

I have 2FA and use SSH instead of HTTPS.
EDIT: The tests are passing, forgot to add this. Also updated the snapshot for this.

ERROR: Permission to electron/fiddle.git denied to arnitkun.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[erickzhao]

Hi @arnitkun, you would want to fork the repository first, since your account does not have push access for electron/fiddle.

For more details: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

[arnitkun]

yeah, sorry I forgot I can do that.