Fiddle: `electron-default-menu` package uses deprecated app.getName() API

Created on 16 Jul 2020  路  3Comments  路  Source: electron/fiddle

When running Fiddle, we get the following warning message, even though we've removed all direct instances of app.getName() in the Fiddle code:

(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.

This package we depend on for setting up a default menu in Electron still uses the old API. I've submitted a pull request (https://github.com/carter-thaxton/electron-default-menu/pull/11) to update it, but it's something we should look out for when we eventually upgrade to an Electron version that doesn't support the app.getName() API anymore.

馃尶 upstream

Most helpful comment

New version is published on npm. Should be good to go.

All 3 comments

That module hasn't been updated since 2017. We should be prepared to fork or vendor it.

New version is published on npm. Should be good to go.

@carter-thaxton thanks for the quick response! My comment wasn't personal, I hope you understand where my skepticism was coming from.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

neighthan picture neighthan  路  13Comments

royal-wisdom picture royal-wisdom  路  7Comments

bpasero picture bpasero  路  5Comments

nornagon picture nornagon  路  5Comments

erickzhao picture erickzhao  路  4Comments