Ferdi: Missing sidebar icons in 5.5.0-gm

[ylluminate]

Most sidebar icons are missing in 5.5.0-gm (5.5.0-gm.1893) on macOS 10.15.4:

[kytwb]

@ylluminate Sorry for the inconveniences 🙏 Could you please share your debug information?
Via _Help_ > _Copy/Publish Debug Information_

[ylluminate]

Sent via email just in case @kytwb.

[janjurek]

The same happens to me as well in 5.5.0.2116 on MacOS 10.15.3 . Seems like custom icon is always setting null icon. If I create new service It has the default icon until a change it to custom, then there is no way back, only delete of the service to get the default icon back.

[xenithorb]

Can confirm 5.5.0 Flatpak on Fedora 31 - custom icon services do not show icons.

[machbio]

Same issue - missing Icon on Custom Services

{"host":{"platform":"darwin","release":"18.7.0","screens":[{"id":69734410,"bounds":{"x":0,"y":0,"width":1680,"height":1050},"workArea":{"x":0,"y":23,"width":1680,"height":947},"accelerometerSupport":"unknown","monochrome":false,"colorDepth":24,"colorSpace":"{primaries_d50_referred: [[0.6818, 0.3196],  [0.2846, 0.6747],  [0.1562, 0.0528]], transfer:0.0777*x + 0.0000 if x < 0.0450 else (0.9495*x + 0.0495)**2.3955 + 0.0003, matrix:RGB, range:FULL}","depthPerComponent":8,"size":{"width":1680,"height":1050},"workAreaSize":{"width":1680,"height":947},"scaleFactor":2,"rotation":0,"internal":false,"touchSupport":"unknown"},{"id":452984843,"bounds":{"x":1680,"y":-1110,"width":3840,"height":2160},"workArea":{"x":1680,"y":-1087,"width":3840,"height":2137},"accelerometerSupport":"unknown","monochrome":false,"colorDepth":24,"colorSpace":"{primaries_d50_referred: [[0.6560, 0.3328],  [0.3558, 0.6042],  [0.1558, 0.0673]], transfer:BT709_APPLE, matrix:RGB, range:FULL}","depthPerComponent":8,"size":{"width":3840,"height":2160},"workAreaSize":{"width":3840,"height":2137},"scaleFactor":1,"rotation":0,"internal":false,"touchSupport":"unknown"}]},"ferdi":{"version":"5.5.0","electron":"8.2.3","installedRecipes":[{"id":"NewsBlur","version":"1.0.0"},{"id":"discord","version":"1.1.3"},{"id":"franz-custom-website","version":"1.0.2"},{"id":"github","version":"2.0.0"},{"id":"gitter","version":"1.0.2"},{"id":"googlecalendar","version":"1.0.3"},{"id":"googledrive","version":"1.0.0"},{"id":"instagram","version":"2.0.0"},{"id":"pocket","version":"1.0.0"},{"id":"redditchat","version":"1.0.0"},{"id":"skype","version":"1.3.0"},{"id":"slack","version":"1.0.15"},{"id":"steamchat","version":"1.0.1"},{"id":"telegram","version":"3.0.0"},{"id":"tweetdeck","version":"1.0.2"},{"id":"twitch","version":"1.0.0"},{"id":"twitter-dm","version":"1.0.0"},{"id":"whatsapp","version":"2.0.3"}],"devRecipes":[],"services":[{"id":"b5b07eca-7001-4218-b591-9d16b5b9bf74","recipe":"whatsapp","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":false},{"id":"abaf68f9-ce14-485b-8253-f8c53fdb247f","recipe":"googlecalendar","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"94ffaf93-0cd3-421a-9cd4-d532a2da29a8","recipe":"franz-custom-website","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"ed2a778d-398d-4f2e-99b3-58b26f97f3c2","recipe":"franz-custom-website","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"2964341b-38fd-468a-9b6f-f1ba18ce5a99","recipe":"twitter-dm","isAttached":true,"isActive":true,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"4514a883-d057-4378-a7d2-298203b1212f","recipe":"tweetdeck","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"fa9c7b4b-062b-4a3a-99f5-906160c3fa67","recipe":"gitter","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"3a8ada5c-dd34-41b7-aa12-443f4dc12df9","recipe":"skype","isAttached":false,"isActive":false,"isEnabled":false,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"e25d7180-712b-4d85-9440-71241eb38854","recipe":"slack","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"8beb4ec3-3027-4cf7-8ebe-c6a1c6a481b0","recipe":"pocket","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"567dd83d-8a1a-446e-b449-67478ee17f56","recipe":"github","isAttached":false,"isActive":false,"isEnabled":false,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"ec1171ec-2b4e-446f-8efd-29a695b37953","recipe":"discord","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"14ff3e91-14ad-4363-aa3f-1e6fc3c9c9a9","recipe":"telegram","isAttached":false,"isActive":false,"isEnabled":false,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":true},{"id":"9a307927-5fb1-431c-a9dc-f29552f38230","recipe":"instagram","isAttached":true,"isActive":false,"isEnabled":true,"isHibernating":false,"hasCrashed":false,"isDarkModeEnabled":false}],"messages":[{"type":"error","info":["error","[mobx] Encountered an uncaught exception that was thrown by a reaction or observer component, in: 'Reaction[Autorun@160]'",{}]},{"type":"error","request":{"result":null,"wasExecuted":true,"method":"getInfo"},"error":{},"response":{},"server":"You are using Ferdi without a server"},{"type":"error","request":{"result":null,"wasExecuted":true,"method":"features"},"error":{},"response":{},"server":"You are using Ferdi without a server"},{"type":"error","request":{"result":null,"wasExecuted":true,"method":"all"},"error":{},"response":{},"server":"You are using Ferdi without a server"}],"workspaces":[],"windowSettings":{"width":2474,"height":1157,"x":2893,"y":-825,"displayBounds":{"x":1680,"y":-1110,"width":3840,"height":2160},"isMaximized":false,"isFullScreen":false},"settings":{"autoLaunchInBackground":false,"runInBackground":true,"reloadAfterResume":true,"enableSystemTray":true,"startMinimized":false,"minimizeToSystemTray":false,"privateNotifications":true,"showDisabledServices":false,"showMessageBadgeWhenMuted":true,"showDragArea":true,"enableSpellchecking":true,"spellcheckerLanguage":"en-us","darkMode":true,"locale":"en-US","fallbackLocale":"en-US","beta":false,"isAppMuted":false,"enableGPUAcceleration":true,"serviceLimit":5,"server":"You are using Ferdi without a server","predefinedTodoServer":"https://todo.microsoft.com/?app#","autohideMenuBar":false,"lockingFeatureEnabled":false,"locked":false,"lockedPassword":"******","useTouchIdToUnlock":true,"scheduledDNDEnabled":true,"scheduledDNDStart":"19:00","scheduledDNDEnd":"07:00","hibernate":false,"hibernateOnStartup":true,"hibernationStrategy":"3600","inactivityLock":0,"automaticUpdates":true,"showServiceNavigationBar":true,"universalDarkMode":true,"adaptableDarkMode":true,"accentColor":"#7367f0","serviceRibbonWidth":68,"iconSize":20,"sentry":false,"navigationBarBehaviour":"always","customTodoServer":"","noUpdates":false,"todoServer":"isUsingCustomTodoService"},"features":{"isSpellcheckerIncludedInCurrentPlan":true,"needToWaitToProceed":false,"needToWaitToProceedConfig":{"delayOffset":3600000,"wait":10000},"isServiceProxyEnabled":true,"isServiceProxyIncludedInCurrentPlan":true,"isAnnouncementsEnabled":true,"isWorkspaceIncludedInCurrentPlan":true,"isWorkspaceEnabled":true,"isCommunityRecipesIncludedInCurrentPlan":true,"isSpellcheckerPremiumFeature":false,"isServiceProxyPremiumFeature":true,"isWorkspacePremiumFeature":false,"isSettingsWSEnabled":false,"isServiceLimitEnabled":false,"serviceLimitCount":0,"isCommunityRecipesPremiumFeature":false,"isCustomUrlIncludedInCurrentPlan":true,"isMagicBarEnabled":true,"isTeamManagementIncludedInCurrentPlan":true,"isTodosEnabled":true,"isTodosIncludedInCurrentPlan":true,"defaultTrialPlan":"franz-pro-yearly","subscribeURL":"https://getferdi.com","planSelectionURL":"https://getferdi.com","hasInlineCheckout":true,"isPlanSelectionEnabled":false,"isTrialStatusBarEnabled":false,"canSkipTrial":true,"pricingConfig":{"currency":"$","currencyID":"USD","plans":{"personal":{"monthly":{"id":"ferdi-free","price":0,"billed":0},"yearly":{"id":"ferdi-completely-free","price":0,"billed":0}},"pro":{"monthly":{"id":"ferdi-still-free","price":0,"billed":0},"yearly":{"id":"ferdi-forever-free","price":0,"billed":0}}}}},"user":"82c1cf9d-ab58-4da2-b55e-aaa41d2142d8"}}

[CypherNL]

The issue still exist in version 5.5.1-nightly.15 on Windows (win32). Changing the icon of a custom website app results in a blank icon.

[ylluminate]

Any news here?

[larena1]

Started using Ferdi yesterday, ran into the same issue. @vantezzen is this a wontfix?

[jbirnick]

Same problem, please fix.

[vantezzen]

@vantezzen is this a wontfix?

As neither me nor the other core contributors can reproduce this bug, we cannot develop a fix for it. For everybody experiencing this, feel free to set up a development instance of Ferdi locally to dive into the code. We'll be happy to accept any PRs fixing this issue.

[jbirnick]

@vantezzen is this a wontfix?

As neither me nor the other core contributors can reproduce this bug, we cannot develop a fix for it. For everybody experiencing this, feel free to set up a development instance of Ferdi locally to dive into the code. We'll be happy to accept any PRs fixing this issue.

I would love to help but I have no overview over the code and no knowledge of web development. The bug was introduced in one of the last versions. Couldn't you just take a look at the part where the custom icon is set and see what changes have been made to these lines in the last versions?
Or tell me the files/functions where the custom icon is set, and I will have a look at the recent changes... @vantezzen

[ymenard-dev]

Hello,
I have open a PR to fix the issue.
Issue explained in the pr.
Regards

[ylluminate]

Any news new beta bin drop with this integrated?

[ymenard-dev]

I have tested the version 5.6.0-beta.2
Seems to be working for me now.
Could you confirm as well ?

[ylluminate]

Do you have a macOS build? For some reason the beta drops don't appear to have binary releases yet as far as I've seen.

[ylluminate]

The 5.6.0-beta.2 resolved the sidebar icon problem. Thanks @ymenard-dev for figuring this out and fixing.

[GuillaumeSorel]

Fixed! Thanks