Got some suggestions for reducing Ferdi's app size, because it's rather big and takes a while to download from GitHub's servers:
Ferdi comes with 133 MB worth of spellchecking. Is it possible to use the OS spellchecker? Otherwise, the spellchecking could dynamically download the appropriate language.
Judging by app.asar, Ferdi's code seems to not be fully minified. UglifyJS is probably a good bet. Is tree shaking in use?
The app.asar is 70 MB, which is quite a bit (Discord, for instance, is 5MB). I guess there's some bloat that could be removed?
probablykasper
All 4 comments
- We could download spellchecker files into the user folder when the user selects a language. Alternatively, we could think about switching to electron-spellchecker as it looks to have a functionality like this implemented by default.
- I'll add this to our gulp buildfile
vantezzen
on 12 Oct 2019
I now added minification for production builds via 362d034. We'll see if that improves the size.
vantezzen
on 12 Oct 2019
I now implemented the switch from the custom spellchecker solution to electron-spellchecker via 64824a6. This reduced the size of Ferdi's build folder from ca. 150MB to ca. 15MB.
electron-spellchecker will use the system's dictionaries or download the dictionaries into the appdata folder as needed.
vantezzen
on 19 Oct 2019
@vantezzen well done!
kytwb
on 20 Oct 2019
Related issues
Jendker
路
3Comments
ammarmalhas
路
3Comments
avielc
路
3Comments
yourcontact
路
3Comments
sbienkow
路
3Comments
Most helpful comment
I now implemented the switch from the custom spellchecker solution to
electron-spellcheckervia 64824a6. This reduced the size of Ferdi'sbuildfolder from ca. 150MB to ca. 15MB.electron-spellcheckerwill use the system's dictionaries or download the dictionaries into the appdata folder as needed.