Ferdi: Zoom doesn't work

[markwalkom]

Describe the bug
Zoom doesn't work

To Reproduce
Steps to reproduce the behavior:

1. In the main app
2. Use command and +/-
3. Or use the View > Zoom in/out
4. Nothing happens

Expected behavior
Text size should alter

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: macOS 10.14.6 (18G103)
• Browser N/A
• Version 5.4.0-beta.2 (5.4.0-beta.2.690)

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Maybe related https://github.com/meetfranz/franz/issues/1289

[vantezzen]

Could reproduce bug and found issue. I'll implement it upstream.

Edit: Fixed by franz#1668

[falkenhawk]

is there any workaround possible in the meantime? e.g. manually setting zoom level for a service in a config file?

[kytwb]

@falkenhawk I have cherry-picked @vantezzen commit and pushed it to our develop branch via https://github.com/getferdi/ferdi/commit/a28c993d2045c3bef61a4435737e0c810d380282. It will ship in our next (beta) release.

[kytwb]

Available in v5.4.1-beta.1.

[markwalkom]

I can zoom out, but I can't zoom in beyond the original 100%. It's not a
big problem for me.

On Thu, 28 Nov 2019 at 13:31, Amine Mouafik [e-mail]
wrote:

Available in v5.4.1-beta.1
https://github.com/getferdi/ferdi/releases/tag/v5.4.1-beta.1.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getferdi/ferdi/issues/143?email_source=notifications&email_token=AAYJQTQISGKXTWYR2CZQQD3QV4UQJA5CNFSM4JCWRQ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLH3NQ#issuecomment-559316406,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYJQTUS54JP3JAOHCBZ5A3QV4UQJANCNFSM4JCWRQ3A
.

[kytwb]

@markwalkom I managed to do both:

Can you give me more details on what prevents you to zoom in beyond 100%?
Is the menu entry View > Zoom in grayed out?

[markwalkom]

Sorry, I should have mentioned this is when I use the keyboard shortcuts,
so command and +

On Thu, 28 Nov 2019 at 16:08, Amine Mouafik [e-mail]
wrote:

@markwalkom https://github.com/markwalkom I managed to do both:

[image: Screen Shot 2019-11-28 at 12 05 10 PM]
https://user-images.githubusercontent.com/412895/69778599-7d891c80-11d7-11ea-8180-f5a2d3626829.png

[image: Screen Shot 2019-11-28 at 12 05 27 PM]
https://user-images.githubusercontent.com/412895/69778600-7e21b300-11d7-11ea-8663-c988c1dbbd64.png

Can you give me more details on what prevents you to zoom in beyond 100%?
Is the menu entry View > Zoom in grayed out?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getferdi/ferdi/issues/143?email_source=notifications&email_token=AAYJQTSGN3FD3O32MBRSXRTQV5G4BA5CNFSM4JCWRQ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLORHQ#issuecomment-559343774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYJQTQC36SV3K3LP5CLTYTQV5G4BANCNFSM4JCWRQ3A
.

[kytwb]

You need to press the shift key at the same time to trigger CMD-+, otherwise you are most likely triggering CMD+= (depending on your keyboard layout).

[markwalkom]

Doh!

On Thu, 28 Nov 2019 at 16:25, Amine Mouafik [e-mail]
wrote:

You need to press the shift key at the same time to trigger CMD-+,
otherwise you are most likely triggering CMD+= (depending on your keyboard
layout).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getferdi/ferdi/issues/143?email_source=notifications&email_token=AAYJQTUZ6PCTQZRPBDDRYW3QV5I3PA5CNFSM4JCWRQ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLPLOY#issuecomment-559347131,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYJQTVHF6SLQ43G22YHWITQV5I3PANCNFSM4JCWRQ3A
.