Ferdi: Replace leftover Franz references

Created on 19 Sep 2019 · 6Comments · Source: getferdi/ferdi

I found a few more Franz references....
In the settings Menue we have "show franz in info area" and "Activate franz todos"
Seen here: https://i.imgur.com/T5UmPfI.png
In the Menu under "?" -> "lean more" it still links to the franz homepage,
Changelog links to the franz changelog,
"Support" links to https://meetfranz.com/support ,
"Terms of service" links to Franz,
"Privacy Statement" also links to franz

Maybe some are intentional or required, especially the privacy statement because we use their servers? Not sure, but the rest should probably be changed.

Source

AGCaesar

👍1

All 6 comments

Good catch, thanks for reporting!

it still links to the franz homepage

I just got getferdi.com, so I think we can start referencing to (https://)getferdi.com when needed!

kytwb on 19 Sep 2019

🚀1

Thanks for your feedback.
I have now finally added a new npm run apply-branding script that automatically replaces the Franz branding with the Ferdi branding in all locales. This should now mean that the only time we get leftover Franz references is, when they are hard-coded and not stored in the translation files.

vantezzen on 19 Sep 2019

🚀1

Is the "npm run apply-branding" performed automatically during build or do I have to change the Arch Linux package build do fix this? Sorry I am a total electron/npm noob.

AGCaesar on 19 Sep 2019

Is the "npm run apply-branding" performed automatically during build or do I have to change the Arch Linux package build do fix this? Sorry I am a total electron/npm noob.

You don't have to change anything in your package. The script will automatically be applied when pushing to GitHub, so the translations on GitHub are already fixed.
Additionally, one can manually run npm run prepare-code or npm run apply-branding to manually apply the branding before pushing it to GitHub.

vantezzen on 19 Sep 2019

🚀1