Ferdi: About menu item now in Todos menu?

[bittner]

Describe the bug

As of version 5.3.3, the "About Ferdi" menu item is found in the new Todos menu. Is this normal? This must be a bug, or at least it's veeery uncommon. :roll_eyes: :smile:

To Reproduce
Steps to reproduce the behavior:

1. Open Ferdi
2. Go to the application menu bar and search for the "About Ferdi" menu item
3. Find the "About Ferdi" menu item in the "Todos" menu
4. There is no "About Ferdi" menu item in neither the "?" menu (natural place) or the "Window" menu (Franz' former choice)

Expected behavior

The "About Ferdi" menu item should be located in the "?" menu (or at least at the same location as Franz has it, provided this is hopefully intuitive).

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu GNU/Linux 18.04.3 LTS Bionic
• Browser: my favorite is Firefox (probably not relevant, haha) :smirk: :smile:
• Version: GNOME 3.28.2

Smartphone (please complete the following information):

• Device: Librem 5 - _the phone that respects your privacy_ :lock: :free: :rocket:
• OS: PureOS - _aiming for UbuntuTouch (aka UBports) in the long run_ :nerd_face:
• Browser: GNOME stock browser (Epiphany)
• Version: (not yet announced)

Additional context

The phone information is a joke, but I donated 100 US$ for the crowdfunding campaign! They are shipping next week!! :smiley: :champagne:

[vantezzen]

Very weird, I can't seem to reproduce this bug on mac.
Using v5.3.3 with Todos enabled, the about menu is still inside the Ferdi menu, not the todo menu.

[justus-saul]

I am able to reproduce it on Ubuntu 18.04.3 LTS with Ferdi 5.3.3.
For Windows I can have a look in the evening at home.

[vantezzen]

Ok, thank you. It looks like Mac uses a different method to build the menu thus the "About Ferdi" option is still in the right place there but not on all other platforms.

It looks like this is the code responsible for this: https://github.com/kytwb/ferdi/blob/b2d887bd5f0775bec6708dc10710c1528f6576ad/src/lib/Menu.js#L867-L869
It pushed the option to the 6th submenu, which was previously the last submenu but is now used for the Todo menu. This should mean that Franz has the same issue.

I have now commited fd8220b, which should have fixed this problem. Hope you can test it in the next beta build.

[kytwb]

@all-contributors add @bittner for bug

[allcontributors[bot]]

@kytwb

I've put up a pull request to add @bittner! :tada:

[kytwb]

@bittner shipped in v5.3.4-beta.1. Can you please test and confirm if the issue is fixed or not on your platform with this version? 🙏

[deadmeu]

@bittner shipped in v5.3.4-beta.1. Can you please test and confirm if the issue is fixed or not on your platform with this version? pray

Looks good for me

[kytwb]

@deadmeu thanks for the feedback!
@bittner please let us know if we need to re-open! 🙏

[bittner]

The "About Ferdi" is in the right place now (the "?" menu). But the "Todos" menu is empty now, which is a bit ... err ... funny! :smile:

Specifically, it has a disabled menu item that says "(empty)".

[vantezzen]

Oh, the todo menu creation threw an error as it used window.franz instead of window.ferdi. 28a7345 should have fixed this error now.