Fenix: [Bug] ETP setting is not persistent

[liuche]

Steps to reproduce

Open any page
Click on the shield icon
Toggle to "on" (if not already on)

Expected behavior

ETP is on if opening shield menu again

Actual behavior

ETP is always off, not persisted

Device information

• Android device: pixel 3
• Fenix version: Nightly 9/9

[liuche]

Should double check that #14785 will not also handle this issue, since it seems similar.

[hwinnemoe]

It is still blocking actively but reports the state falsely in the user-facing UI. This also occurs when it is not visible anymore, as reported in #14785.

[codrut-topliceanu]

I'm unable to reproduce it anymore (I was able to yesterday), except with the steps in https://github.com/mozilla-mobile/fenix/issues/14785.

• Android device: Pixel 3XL (Android 10)
• Fenix version:
  

I'll tag this issue for QA when https://github.com/mozilla-mobile/fenix/issues/14785 gets merged, if that's ok.

[hwinnemoe]

I can still reproduce on Nightly 200915 06:08.

[hwinnemoe]

This is now fixed in Nightly 200920 06:02 (Build #2015764977).

[AndiAJ]

Hi, verified as fixed along with #14785 & #15152 on the latest Nightly Build 200921 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)