Fenix: FNX2-15669 ⁃ [Bug] leak after downloading a file (SimpleDownload DialogFragment Leaked)

Created on 29 Jul 2020 · 3Comments · Source: mozilla-mobile/fenix

Steps to reproduce

Have LeakCanary enabled
Download a file (I downloaded a .apk file)

Expected behavior

No leak.

Actual behavior

SimpleDownload DialogFragment Leaked

┬───
│ GC Root: System class
│
├─ android.view.accessibility.AccessibilityManager class
│ Leaking: NO (BrowserFragment↓ is not leaking and a class is never leaking)
│ ↓ static AccessibilityManager.sInstance
├─ android.view.accessibility.AccessibilityManager instance
│ Leaking: NO (BrowserFragment↓ is not leaking)
│ ↓ AccessibilityManager.mAccessibilityStateChangeListeners
├─ android.util.ArrayMap instance
│ Leaking: NO (BrowserFragment↓ is not leaking)
│ ↓ ArrayMap.mArray
├─ java.lang.Object[ ] array
│ Leaking: NO (BrowserFragment↓ is not leaking)
│ ↓ Object[].[2]
├─ org.mozilla.fenix.browser.BrowserFragment instance
│ Leaking: NO (Fragment#mFragmentManager is not null)
│ ↓ BrowserFragment.downloadsFeature
│ ~~~~
├─ mozilla.components.support.base.feature.ViewBoundFeatureWrapper instance
│ Leaking: UNKNOWN
│ ↓ ViewBoundFeatureWrapper.feature
│ ~~~
├─ mozilla.components.feature.downloads.DownloadsFeature instance
│ Leaking: UNKNOWN
│ ↓ DownloadsFeature.dialog
│ ~~
╰→ mozilla.components.feature.downloads.SimpleDownloadDialogFragment instance
Leaking: YES (ObjectWatcher was watching this because mozilla.components.feature.downloads.SimpleDownloadDialogFragment received Fragment#onDestroy() callback and Fragment#mFragmentManager is null)
key = ed2c55fc-0738-44df-9e79-2f36fd9cff25
watchDurationMillis = 8423
retainedDurationMillis = 3419