Fenix: [Bug] "Report Site Issue" icon does not use correct colors and icons for light and dark themes

Created on 9 Jun 2020  ·  5Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

Set Fenix in dark mode
Open Addon submenu in Fenix main menu (in a page)
Check the icon near to "Report Site Issue"

Expected behavior

Icon is white as other Fenix menu icons

Actual behavior

Icon is black

Device information

  • Android device: Redmi Note 7 Miui 11 Android 9
  • Fenix version: #2015745203
WebExtensions ac gv 🐞 bug

Most helpful comment

We're also tracking this at https://bugzilla.mozilla.org/show_bug.cgi?id=1644451, fwiw.

All 5 comments

@ekager @mcarare
https://github.com/mozilla-mobile/android-components/blob/master/components/feature/webcompat-reporter/src/main/assets/extensions/webcompat-reporter/manifest.json#L47
adding here theme_icons does nothing (broken feature?).
https://discourse.mozilla.org/t/use-theme-colors-for-svg-favicons/29165/2

"theme_icons": [{
      "light": "icons/lightbulb.svg",
      "dark": "icons/darkbulb.svg",
      "size": 16
    }, {
      "light": "icons/lightbulb.svg",
      "dark": "icons/darkbulb.svg",
      "size": 32
    }]

Is there another way i can do?

cc: @denschub

We're also tracking this at https://bugzilla.mozilla.org/show_bug.cgi?id=1644451, fwiw.

Hi. any update on that issue? Now that the icon moved to the main menu, the color inconsistency in dark mode is more visible and quite obvious. Thanks ;)

Was this page helpful?
0 / 5 - 0 ratings