Fenix: [Bug] Newly-available addons that were installed before Preview cannot be enabled

[BeeeWall]

Steps to reproduce

1. Using a pre-Fenix version of Nightly, install a few addons that are now available, like Dark Reader and HTTPS Everywhere, as well as uBlock Origin.
2. (For comparison) Install the build of Fenix where uBlock got enabled. It worked fine.
3. Install the latest update and try to enable HTTPS Everywhere and Dark Reader.
4. (For comparison) Install another newly-available addon, such as NoScript.

Expected behavior

They will enable fine and work, just like the uBlock update did if you had uBlock previously, and just like newly-installed addons do.

Actual behavior

The addon says it's enabled, but it does not move to the Enabled section, and does not work when browsing. If the app is closed and reopened, the addon page shows it as disabled again.

Device information

• Android device: Samsung Galaxy S10e on the Android 10-based One UI 2.1
• Fenix version: 200416 8:30 (Build #2015734851)

[Amejia481]

This will be fixed after this pr lands https://github.com/mozilla-mobile/android-components/pull/6693 and Fenix picks the new version on AC that contains it

[BeeeWall]

Oops, didn't realize an issue had been filed over there already. Didn't think to check.

Thanks for fixing it so quickly!

[Amejia481]

This should be fixed in master, @AndiAJ would you mind taking a look? :)
Related issue https://github.com/mozilla-mobile/android-components/issues/6685

Be aware that now we are enabling the newly supported add-ons when the notification is shown.

[AndiAJ]

Hi @Amejia481 , I've just checked this matter using a Google Pixel 3a (Android 10) using the following scenarios:

1st scenario

Fennec → Fenix GV 76 from 4/6 → Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22

► Video after migrating from Fenix GV 76 from 4/6 → Fenix GV 77 from 4/16

❌ The Add-ons are disabled after the migration
❌ If you enable them, each time you re-open them they are enabled over and over
❌ The notification is displayed each time you open Fenix
❓ Bumped into a "Failed to querry Add-ons!"error after closing Fenix and resuming it.
Due to this no notification get's displayed

► Video after migrating from Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22

❌ The Add-ons are disabled after the migration
❌ If you enable them, each time you re-open them they are enabled over and over
❓ No notification is displayed
❓ Bumped into a "Failed to querry Add-ons!"error after closing Fenix and resuming it.

2nd scenario

Fennec → Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22

► Video after migrating Fennec → Fenix GV 77 from 4/16

✔️ The Add-ons are enabled after the migration
✔️ The enable/disable state is properly displayed
✔️ No notification is displayed (as they are installed)
❓ Bumped into a "Failed to querry Add-ons!"error after closing Fenix and resuming it.

► Video after Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22

✔️ The Add-ons are enabled after the migration
✔️ The enable/disable state is properly displayed
✔️ No notification is displayed (as they are installed)
❓ Bumped into a "Failed to querry Add-ons!"error after closing Fenix and resuming it.

Please review and share your thoughts. ☺️
I'll remove the QA needed label until further notice.

[BeeeWall]

It seems to have been fixed (at least for me) so I'm gonna close this.

[Amejia481]

Sorry, @AndiAJ would you mind re-testing. Test the latest build from master, as it will have the fix. Also be aware, if you have a previous open instance of Fenix, you have kills from the task switcher and open it again.

[Amejia481]

@BeeeWall Thanks for verifying :)
I opened it again as we need QA verifies the issue in multiple devices.

[BeeeWall]

Oops, my bad then.

[AndiAJ]

Hi, verified as fixed after updating to the latest Nightly Build #2015736177 from 4/23 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• Samsung Galaxy S7 (Android 7)

Performed the following updates:
Fennec → Fenix GV 76 from 4/6 → Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/23

► Video after migrating Fenix GV 77 from 4/16

► Video after migrating to the latest Fenix GV 77 from 4/23 ✔️

Great job @Amejia481 ! ☺️

[Amejia481]

We receive a report of this issue. It would be pretty helpful if QA can help us to determine if this still an issue.

The user was using 77.0.0-beta.2

[Amejia481]

It will be ideal if we can test on Xiaomi devices, as it was the device where the user is experiencing the issue.

[sflorean]

Tested this with Xiaomi Redmi Note 8T (Android 9) on Nightly and Beta channels, and couldn't reproduce the issue.
For Fennec - Fenix 77.0.0-beta2 -> followed this scenarios :

• disable the addons > migrate > enable them;
• enable > migrate > disable/enable.

For Fennec > Fenix GV 76 from 4/6 > Fenix GV 77 from 4/16 >Latest Fenix GV 77 from 4/22 > latest Beta 76.0.0-beta2 - addons were enabled on the last build.

[Amejia481]

It will be ideal if we can test on Xiaomi devices, as it was the device where the user is experiencing the issue.

We can close this issue, as we discovered that the reported bug is not related to add-ons, it's due to some devices that are not able to run WorkManager, we are going to open a new issue for it.

[csadilek]

It's due to some devices that are not able to run WorkManager, we are going to open a new issue for it:

https://github.com/mozilla-mobile/android-components/issues/7659