Fenix: [Bug] Don't allow duplicate collection names

[softvision-miralobontiu]

Why/User Benefit/User Problem

I don't believe the user should be allowed to save the same tabs in a different collection that has the same name. Or much easier to understand, the user shouldn't be able to duplicate a collection.

[softvision-miralobontiu]

Closing as a dupe of #2917

[J-Siu]

@softvision-miralobontiu I believe this is not the same as #2917 .

If I understand correctly, #2917 Is about duplicate entries within a collection.

But this issue is about creating collections with the same name. Referring the the screenshot above, you can see 2 "Medium" collections. I am able to reproduce this on nightly build#21080611. Maybe this should reopen and categorize as bug?

[softvision-miralobontiu]

@J-Siu thank you for the feedback!
I'll reopen the issue, and see what happens next.

[J-Siu]

Adding screenshot to show issue more clearly:

[cadeyrn]

Well… the name of a collection is chosen by the user itself. If someone wants to create a few collections with the same name it's an explicit user decision. Why should Fenix restrict this? Just don't create multiple collections with the name if you don't want this… 🤔

[J-Siu]

If collections having same name, then they should be one collection. I actually discover this by accident when I type Media for new collection. It is actually confusing.

[cadeyrn]

Why? I still don't see the argument why Fenix should restrict how users can use the collections feature if there is no technical reason to forbid this case.

[J-Siu]

Allowing multiple collections with the same name is just confusing, no helping user.

[softvision-miralobontiu]

This is still reproducible on the latest Nightly build from 1/4.