Fenix: [Bug][a11y]Sharing the opened tabs doesn't differentiate the close button and Share title

Created on 31 Mar 2020  ·  8Comments  ·  Source: mozilla-mobile/fenix

Prerequisites

Talkback needs to be enabled.

Steps to reproduce

  1. Open any page;
  2. Go to the homepage of the app;
  3. Open the 3dot menu from the "Open tabs" section;
  4. Tap on the "Share tabs" button;
  5. Focus the Talkback to the "X" button.

Expected behavior

The close button is read by the Talkback.

Actual behavior

The "X" button with "Share" title are focused and read as "Share button"

Device information

Android device:

  • Google Pixel 3 (Android 10);
  • Samsung Galaxy Note 8 (Android 9).

Fenix version: Firefox Preview Nightly 3/31 #20910606.
Screenshot_20200331-135433_Firefox Nightly

Sharing P2 S2 a11y engverified ready 🐞 bug

All 8 comments

It's the same for 'Select Tabs' to save to collection view. The button includes the whole title:

Samsung Galaxy S9+ (Android 8.0.0)
Firefox Preview 4.2.0

20200331_133744

This is an accessibility P2. The feature is available and works but is difficult to use because of misleading button labeling. This kind of bug prevents Fenix from being a delightful experience for users with disabilities.

@asadotzler Will a content description of "Close" suffice for both? The action is the same, closing that screen, even though one icon is close and the other is back.
Maybe UX can clarify why there is a difference?

@mcarare Hmm. This is odd. We expected that only the close/back button would be highlighted. The page title should never be included in the selection, unless it’s highlighted separately.

@mcarare I also see what you’re saying about why we sometimes have a back icon, and sometimes it’s close. I agree that it’s inconsistent. Let’s file a new issue for this – something that we want Content Strategy to be aware.

@mcarare Filed #10105.

Verified as fixed on the latest Nightly build 6/3 with Google Pixel 3 (Android 10) following the steps from the description.

The issue described in here is not fixed, the back button isn't highlighted.
@mcarare this will be covered in a different bug?

Was this page helpful?
0 / 5 - 0 ratings