Fenix: [Bug] show in private sessions button is too small

Created on 20 Feb 2020 · 3Comments · Source: mozilla-mobile/fenix

Settings P3 engverified implementation review triage 🐞 bug

Source

sblatz

Most helpful comment

@AmyYLee This was intentional, because the smaller space between the preference above indicates the fact that this is dependant on that. An alternative would be make it the same size, but indent the checkbox. What is your suggestion?

@mcarare Hi, the suggestion was to give more space to the padding under "Show in private sessions" because it's very close to the bottom navigation and not the space above it.

AmyYLee on 11 Mar 2020

👍2

All 3 comments

@AmyYLee This was intentional, because the smaller space between the preference above indicates the fact that this is dependant on that. An alternative would be make it the same size, but indent the checkbox. What is your suggestion?

mcarare on 11 Mar 2020

@AmyYLee This was intentional, because the smaller space between the preference above indicates the fact that this is dependant on that. An alternative would be make it the same size, but indent the checkbox. What is your suggestion?

@mcarare Hi, the suggestion was to give more space to the padding under "Show in private sessions" because it's very close to the bottom navigation and not the space above it.

AmyYLee on 11 Mar 2020

👍2

Hi, verified as fixed on the latest Nightly Build #20800605 from 3/20 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S6 (Android 7)
• OnePlus A3 (Android 6.0.1)

Comparison Nightly Build #20780606 3/18 VS Nightly Build #20800605 3/20 (Dropdown)

► ❌ Video Nightly Build from 3/18
20200320-084037