Fenix: Advanced block autoplay settings

[vesta0]

User Story

As a user, I want to be able to block Audio only or choose how autoplay is blocked over wifi, so I can control my experience to match my needs.

Dependencies

GV: https://bugzilla.mozilla.org/show_bug.cgi?id=1593843#c27

See #255 for original issue

See mocks

Acceptance Criteria

-I can choose to only block audio. When I block audio only, only audio is blocked
-I can choose to allow audio and video over wifi only. When I am not on wifi, audio and video are blocked, and when I am on wifi audio and video auto play.

[severinrudie]

It looks like newer versions of Android encourage us to check "is this an unmetered connection?" instead of "are we on WIFI?" @vesta0 should we stick with "allow on WIFI" or change to "allow on unmetered"?

[vesta0]

Good point @Baron-Severin Let's see what @betsymi thinks!

[sv-ohorvath]

@vesta0 @Baron-Severin, @liuche included this in the 4.1 release notes, but I don't see any changes on Beta 4.1 or Nightly and the PR looks like is still open. Should there be anything to verify on this issue for now?

[betsymi]

@vesta0 @Baron-Severin @liuche included this in the 4.1 release notes, but I don't see any changes on Beta 4.1 or Nightly and the PR looks like is still open. Should there be anything to verify on this issue for now?

Am still working on unpacking this. For a future state, I don't think this is a simple matter of changing the strings we have. May need to make adjustments in the design to provide more clarity for users, particularly regarding Allow audio and video on Wi-Fi only. Does this means that audio and video will be blocked on cellular data?

[liuche]

@sv-ohorvath that was my mistake! I've removed it from the release notes.

[severinrudie]

Does this means that audio and video will be blocked on cellular data?

@betsymi correct.

@lime124 (sorry I don't know who designed this feature!) we recently discovered that GV always blocks autoplay over cellular data (i.e., the top two radio buttons do the same thing). The only short term solution I can think of is removing the top button. If you think it's important, we will have to ask GV to prioritize https://bugzilla.mozilla.org/show_bug.cgi?id=1621825.

[vesta0]

@topotropic ^^

[betsymi]

New strings. If option 1 and 2 are the same, we can consolidate to one option. Also, to make all options easier for users to parse, I've adjusted the copy to begin with the same verb.

Block audio and video on cellular data only
Audio and video will play on Wi-Fi

Block audio only

Block audio and video
Recommended

[severinrudie]

We've had to change these strings a few times, so I've reached out to the localization team on how they want me to handle updating them again. I should hear back soon, and then I'll merge in these changes. Thanks everyone!

[severinrudie]

Note to QA: for various reasons, there have been a few changes to the spec:

• There will only be three bullet points for autoplay (the top one was dropped for now)
• Strings should match this comment
• Because of this bug, muted autoplay is not currently working (also true on master)

[sv-sdeiac]

Hi, I can confirm that this issue is fixed using the latest Firefox Preview Nightly 3/23 #20830607.
Also, thanks @Baron-Severin for your information.

Devices:

• Google Pixel 3 (Android 10);
• Samsung Galaxy Tab S6 (Android 9);
• LG g7 fit (Android 8.1).

Additionally. I tested the "Block audio and video on cellular data only" option and it seems that this option is not working. The autoplay is still playing even when I am on the mobile data.
@Baron-Severin Can you take a look there and come with more info? I'll remove the qa:needed and wait for your updates, thanks.

[severinrudie]

Additionally. I tested the "Block audio and video on cellular data only" option and it seems that this option is not working. The autoplay is still playing even when I am on the mobile data.

I'm on PTO this week, @Amejia481 would you mind taking a quick look? This is the BZ ticket, this is the code that I thought blocked on cellular data.

The easiest approach here might just be to reenable our wifi logic. That should be super easy. Search in the project for 1621825 and you'll find comments about how to hook it back up.

[Amejia481]

No problem I can take a look!

[sv-ohorvath]

@liuche FYI, this has landed on Beta 4.2 with a defect, see https://github.com/mozilla-mobile/fenix/issues/8017#issuecomment-602569535. And there is https://github.com/mozilla-mobile/fenix/issues/5636 as well.

[Amejia481]

Hi, I can confirm that this issue is fixed using the latest Firefox Preview Nightly 3/23 #20830607.
Also, thanks @Baron-Severin for your information.

Devices:

* Google Pixel 3 (Android 10);

* Samsung Galaxy Tab S6 (Android 9);

* LG g7 fit (Android 8.1).

Additionally. I tested the "Block audio and video on cellular data only" option and it seems that this option is not working. The autoplay is still playing even when I am on the mobile data.
@Baron-Severin Can you take a look there and come with more info? I'll remove the qa:needed and wait for your updates, thanks.

This pr https://github.com/mozilla-mobile/fenix/pull/9372 should fix the issue.

[sv-sdeiac]

Hi, I can confirm that the issue found previously is now fixed using the latest version of Firefox Preview Nightly 3/29 #20891805.

Device: Huawei P40 lite (Android 9).