Fenix: [Bug] Private mode doesn't play nicely with sites added to home screen

[sblatz]

Steps to reproduce

1. Add a site to home screen in private mode
2. Open the site from your android home

Expected behavior

1. Site opens in whatever mode you are currently in

Actual behavior

1. Site opens in normal mode

Device information

• Android device: Galaxy S9
• Fenix version: Android Nightly 1/30/20

[mcarare]

@sblatz Is this supposed to work in private?

[sblatz]

I'm not 100% sure. It feels weird to me that it switches to private mode, but let me ask @NotWoods 😄

[NotWoods]

I don't think we've defined this anywhere. I'm currently working on tweaking the PWA site controls notification to indicate if a PWA is in private mode. Personally, I think that the PWA should match whichever mode you were in when you installed it, and update the menu design to make that more clear.

[NotWoods]

Let's track updating the site controls notification here for now. Later we should ask the UX team for a menu prompt design (maybe integrate a private mode checkbox into https://github.com/mozilla-mobile/android-components/issues/5883).

Notification alterations:

• Instead of the Firefox logo, show the private mode mask
• Instead of "PWA Name", show "PWA Name (Private Mode)". (ie: Twitter (Private Mode)).
• Instead of the PWA color, use the private mode color.

[TitanNano]

@NotWoods you can assign this to me 😄

[klint]

Just to be clear, as the discussion focused on PWA only eventually, the request here is about both PWA and page shortcuts added to the phone's home screen. Not only about PWA (which are less often available than plain web pages that can be turned into shortcuts, actually).
Thank you

[TitanNano]

@sblatz my patch landed, what's the next step here?

[sblatz]

@TitanNano Let's have QA verify and close this out. Thanks 😄

[softvision-miralobontiu]

Hi all,

This issue is not fixed yet. The page added to the homescreen from private mode, opens in normal mode. Tested on the latest Nightly build from 5/8 @6:06 AM with OnePlus 5T (Android 9), One Plus A3 (Android 6.0.1), Samsung Galaxy Tab A6 (Android 5.1.1), and HTC 10 (Android 8).

[TitanNano]

@softvision-miralobontiu @sblatz see https://github.com/mozilla-mobile/fenix/issues/7996#issuecomment-584892912 my patch only changed the site control notification, getting the PWA to actually launch in private mode seems to be part of https://github.com/mozilla-mobile/android-components/issues/5883. So this is not really testable yet as PWAs are still always in standard mode.