Fenix: [Bug] Can't read text on about screen when in private mode

Created on 30 Dec 2019 · 11Comments · Source: mozilla-mobile/fenix

If you go to the "About Fenix" page in private mode, the text cannot be read. We're probably just using the wrong attribute color here.

PrivateBrowsing Settings P2 S2 engverified ready good first issue help wanted 🐞 bug

Source

sblatz

All 11 comments

@boek I would like to work on this Issue. Can you help me out with a few things?

obitodarky on 31 Dec 2019

Yes, for sure!

How can I help?

boek on 31 Dec 2019

I would like to know which build variant should I work on and where can I find the file which mentions the text color.

obitodarky on 1 Jan 2020

@boek I have worked a bit on this issue, and i needed some help with it. Is there a difference between how the private mode theme works in dark and light modes? If so, then where in the code can i find it because this problem persists just in the light mode

KaairaGupta on 8 Jan 2020

@boek i have fixed the bug and am making a PR. Are there any guidelines that i have to follow for the same? It's my first time with open source

KaairaGupta on 8 Jan 2020

@boek @ekager please review my PR

KaairaGupta on 8 Jan 2020

Reopening for QA

ekager on 9 Jan 2020

@ekager can you please let me know why this issue is reopened? Was there any mistake in my PR, and how should i proceed if there was?

KaairaGupta on 9 Jan 2020

No issue! Our process is just to keep issues open until our QA team can verify that they've been fixed.
In the future, you can use the keyword "For #7414" instead of "Closes #7414" to help me out :)

ekager on 9 Jan 2020

👍1

@ekager The shared documentation states that:

An example commit message summary looks like, Closes #5: Upgrade gradle to v1.3.0.".

Yet, most commits to this repository (as well as other Mozilla repositories) mainly use the For or Fixes keywords instead. Also, I can't find a reference to the For keyword anywhere. Do we just use For when we don't want to automatically close the linked issue and Closes when we do?

tvenissat on 9 Jan 2020

👍1

Hi, verified as fixed on the latest Nightly Build #20100616 from 01/10 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Screenshot
rsz_screenshot_20200110-085717