Fenix: Default device name should show both app and device name

[jonalmeida]

Steps to reproduce

1. Install Fenix.
2. Sign into an account.

Expected behavior

1. ~The default name should be '[app name]' or '[app name] on [device]'~
   
   
   
   • ~e.g. "Firefox Preview" or "Firefox Preview on Pixel 2".~
   
   

⚠️ Update:
Verified format: [user]'s [app name] on device
e.g. "Jonathan's Firefox Preview on Pixel 2"

Actual behavior

1. The default name is '[device] [manufacturer]'.

Device information

• Android device: Android 9
• Fenix version: 03/07/2019

This seems to be a regression from https://github.com/mozilla-mobile/fenix/issues/3317.

cc: @ryanfeeley

[ekager]

Was this default specced out somewhere? It looks like it was a regression w #3317 we just need confirmation of what it should be and then it's just changing the default :)

[jonalmeida]

Yes, here: https://mozilla.invisionapp.com/share/QSR2F8UD4PN#/screens/357470305

The format there is '[app name] on [person]'s [device]' but this was scoped to match desktop which is the format currently used everywhere, i.e. '[app name]' or '[app name] on [device]' .

[vesta0]

I think device name should include both [app name] and [device name] e.g. Firefox Preview on Pixel 3

[liuche]

Waiting on Strings confirmation.

[mheubusch]

Confirmed that it should be [app name] on [device name]

I think what you see in Invision is an artifact of Ryan customizing the name of his device, not pulling in metadata from somewhere else.

[mheubusch]

@liuche strings resolved

[ryanfeeley]

@vesta0 @mheubusch Close. It's best to take a look what Firefox does on other platforms to stay _in sync_. What it does is something like Vesta’s Firefox Preview on Pixel 3.

Related issue: https://github.com/mozilla/fxa/issues/1816

[mheubusch]

@ryanfeeley I'm seeing variance across the board, and was trying to match for Android. Firefox for Android and Firefox Beta for Android don't pull in a user's name either. Is this a Fenix issue or FxA issue? Also, are Firefox for Linux and Pocket and Lockwise displaying correctly too?

[jonalmeida]

Also, are Firefox for Linux and Pocket and Lockwise displaying correctly too?

I don't have a linux device, but here is a screenshot of Lockwise, Pock and Send.

[jonalmeida]

@mheubusch spoke with @ryanfeeley offline: [name]'s [app] on [device] is the way we have to have across all devices eventually so we should do the preferred way here (other platforms will update).

[ryanfeeley]

For any items that can appear multiple times, it would be great to have [name]'s [app] on [device] for all of them.

[softvision-miralobontiu]

This is not fixed yet on the latest Nightly build 190731 (#12120612) with Google Pixel 3 (Android 9), Sony Xperia Z5 Premium (Android 7.1.1), and Windows 10.

This is how the device's names are displayed:

[jonalmeida]

I mentioned this offline, but it seemed a conflict resolution when merging this PR seems to have broken it's functionality: https://github.com/mozilla-mobile/fenix/commit/8ff77b90f388187e04f6a376702c6a10873ea49e

[softvision-miralobontiu]

Verified as fixed on RC 1.2.0-rc.1, and latest Nightly build 190801 with Motorola Moto G6 (Android 8), and Sony Xperia Z5 Premium (Android 7.1.1).