Fenix: FNX3-16907 ⁃ [Bug] Settings do not display correct content

Created on 8 Jun 2019  ·  10Comments  ·  Source: mozilla-mobile/fenix

Steps to reproduce

open settings

Expected behavior

settings match design comps
Should look like this:


Main Settings panel -

  • Second section should be labeled Privacy, not Advanced
  • Data choices should be Data collection
  • :information_source: Privacy Notice should be Privacy notice (no icon, lower case n)
  • Your rights should not appear on the panel - it is accessed via the Help link)
    _Note that Delete browsing data should persist in the app - I will have the design comps updated to reflect this_

    Search settings should have the default setting, Google, at the top of the list. All others can be alpha or random after that.

Crash reporting is no longer in this panel and I will get updated comps, but Telemetry label should be replaced with heading and description for Usage and technical data

Permissions panel should have heading Permissions between the exceptions section and the permission type

Actual behavior

settings don't match design comps

Device information

  • Android device: Pixel 3
  • Fenix version: 1.0.1923 #11581437
P1 strings engverified sumo sourpatch 🐞 bug 🙅 waiting

All 10 comments

The crash one was hard/impossible to implement see #1264 and #1003#issuecomment-478106992

Data choices -> Data collection is part of #2273

Could you be more specific about what this bug is about? Is it just about data collection settings?

For accessibility settings - you have to toggle "Automatic Font Sizing" off to see that text scaling setting.

@vesta0 @mheubusch We can't change strings anymore due to string freeze. How do you want to move forward with this for the MVP?

@boek @vesta0 The only issue that may be critical is the labeling of Telemetry vs what we have in the Data collection panel. I am meeting with legal in an hour to discuss. Will also reach out to Delphine to find out the earliest we can update strings after June 24.

Per a conversation with legal, these are P1 but not MVP blocking issues. I will update the labels and coordinate with Delphine to find out the soonest date we can do this.

@mheubusch I did everything I could minus the string changes for now

Making a note that I have let Joni Chen know that when this change lands, SUMO will need to update their description of how to turn off data collection to read: Firefox Preview: Tap the menu button (three dots) at the top of the screen. Tap Settings, then select Data collection. On the next screen, toggle the switch next to Usage and technical data to turn it off or on.
Screenshot_20190718-102907

Thank you for including SUMO in this work. I will start drafting the change to the KB articles, but so that we can land them in a timely fashion, please can we have a weeks notice of this going to land (please drop me a note on Slack).

So, on the latest Nightly build (190724 #12050609) on Samsung Galaxy Tab A6 (Android 5.1.1), the settings look like this:

settings1

settings2

Data collection look like this:
datacollection

Search engine like this:
searchengine

Site permissions like this:
sitepermission

The only difference from Comment 0 is at "Data collection", where "Crash reporter" info and toggle are missing. @mheubusch is this expected?

Was this page helpful?
0 / 5 - 0 ratings