Fenix: FNX3-16568 ⁃ Option to disable screenshots in private mode

[vesta0]

User Story

• As a user, I want the option to disable taking screenshots in private browsing mode, so I can further protect my privacy.

Acceptance Criteria

• I can disable taking screenshots in private mode (off by default)
• When disabled in private mode, I am not able to take a screenshot and instead I see a system notification indicating that taking screenshots isn't allowed in private mode.
• I don't see the contents of my private tab in Android multitasking view

[topotropic]

We should use a system notification, similar to what Focus does.

[vesta0]

Sounds good @topotropic

[buttercookie42]

Should this be configurable - not least for bug reports and suchlike?

[joebloggs7657]

Could this not be an option? Being able to take screenshots in private mode doesnt exactly compromise the premise of private browsing. I will say from experience in Bromite that not being able to screenshot is more of a hassle than anything related to private browsing.

[yoasif]

This should be an option - perhaps even default behavior, but an option nonetheless, imo.

[ekager]

If we do this, I think we should make it off by default. From Focus experience, not all users understand or want this feature, and the ones that want it are probably more likely to understand how to seek it out.

[lime124]

removing the ux label - this is on our radar already as it's part of Q3 plans.

[Djfe]

this is the same bug as

2248

3422

3707

I think 3 of the 4 bugs should be closed as duplicates :)

[NotWoods]

I've started working on the blocking functionality in Android Components (mozilla-mobile/android-components#4551).

[NotWoods]

The feature has been added and should be incorporated into BaseBrowserFragment, in a similar manner to our list of features inside that fragment.

[KaairaGupta]

@NotWoods is the feature of disabling screenshots on private mode up? Or is there any work still left to do? I asked because this issue was still showing under the good first bugs. If there is any work, i would love to contribute.

[NotWoods]

You can integrate SecureWindowFeature from the feature-privatemode component in our Android Components library. You'll need to edit BaseBrowserFragment and possibly the build.gradle & Dependencies.kt files.

[KaairaGupta]

@NotWoods i can't seem to find this library in the code. Please help me with it.

[KaairaGupta]

Also, should i add the option in the settings or in the three-dot-menu?

[ekager]

AFAICT this issue still needs UX and strings for the Settings decsribed. I don't think this is ready to be worked on yet.

[ekager]

@lime124 adding back the UX label because I don't see any mocks linked

[NotWoods]

@ekager ~Could we land an always on option for now and introduce the toggle later? I think always off makes sense as a default.~ Oops, missed the prior discussion.

@KaairaGupta Here is the docs for SecureWindowFeature.

[ekager]

@NotWoods see comments above. From my experience on Focus, users can find this feature really annoying and I think we should wait for a way for users to turn it off before introducing it. We can get input from @vesta0 though.

[vesta0]

I agree that this should be a user option that is disabled by default. I see that it has the needs:UX-feedback label so let's wait for @brampitoyo to provide feedback.

[lime124]

So sorry I dropped the back let me loop in Amy as well @amylee

On Wed, Jan 22, 2020 at 10:32 AM Vesta Zare [e-mail]
wrote:

I agree that this should be a user option that is disabled by default. I
see that it has the needs:UX-feedback label so let's wait for @brampitoyo
https://github.com/brampitoyo to provide feedback.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-mobile/fenix/issues/2768?email_source=notifications&email_token=AACGEWWQXMKY7VZ5XKKPD5LQ7CGLBA5CNFSM4HO2CMK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJUUAQI#issuecomment-577323073,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACGEWU55QRK22K4NSS24OTQ7CGLBANCNFSM4HO2CMKQ
.

[brampitoyo]

If the code’s complete and ready to land, let’s figure out a place in Settings to put it, and the right string to call it.

I agree with @vesta0 that we probably shouldn’t turn this option on by default.

One thing we have to keep in mind is the “unintended consequence” that turning this option on will also cause Fenix private mode not to show a screenshot in the app manager view – effectively hiding potentially incriminating content. It’s a nice privacy feature, and one that we ought to include when explaining this feature.

[AmyYLee]

I would recommend putting this setting under Settings -> Private browsing and add a toggle to enable/disable. Adding @betsymi for strings

[brampitoyo]

Copy-pasting @betsymi’s response:

This string can read: Allow screenshots in private tabs. And to confirm, should be OFF by default.

[BMEduard]

Hello @AmyYLee @brampitoyo , I have a question regarding the scope of this feature. Should the screenshots be disabled only for tabs?
The example for AC samples suggests this, but what about home, search and other screens, should they also be included?

[AmyYLee]

Hello @AmyYLee @brampitoyo , I have a question regarding the scope of this feature. Should the screenshots be disabled only for tabs?
The example for AC samples suggests this, but what about home, search and other screens, should they also be included?

Copy-pasting @betsymi’s response:

This string can read: Allow screenshots in private tabs. And to confirm, should be OFF by default.

@betsymi Hi, as per discussion above, the consensus is that the default should be to allow screenshots in private tabs.

Do you think we can modify the strings so it reads something like "Don't allow screenshots in private tabs" and have it OFF by default?

[AmyYLee]

Hello @AmyYLee @brampitoyo , I have a question regarding the scope of this feature. Should the screenshots be disabled only for tabs?
The example for AC samples suggests this, but what about home, search and other screens, should they also be included?

I think for consistency we should not show home search and other screens as well if the user chooses this option. There still might be open tabs on homescreen that the user doesn't want exposed. What do you think? @brampitoyo

[brampitoyo]

@AmyYLee is correct. If screenshot is blocked on private tabs, it means that screenshot should also be blocked on every other page, including in-content pages, in private mode.

I wonder if it’s more correct to call this feature “Allow/Don’t allow screenshots in private browsing”? This clarifies the scope. Screenshot is either allowed or blocked in all pages, not just on websites.

[sv-sdeiac]

Hi, I can confirm that the new feature is implemented using the latest version of Firefox Preview Nightly 4/8 #20990609.
Also, I can confirm that the issue works properly. Disabling the option is blocking the device to take screenshots and it blanks the videos. Enabling the option allows the device to take screenshots and videos.

Devices:

• LG g7 fit (Android 8.1);
• Samsung Galaxy Note 8 (Android 9);
• Google Pixel 3 (Android 10).

[Poopooracoocoo]

@brampitoyo said:

One thing we have to keep in mind is the “unintended consequence” that turning this option on will also cause Fenix private mode not to show a screenshot in the app manager view – effectively hiding potentially incriminating content. It’s a nice privacy feature, and one that we ought to include when explaining this feature.

a subtext could be added to explain this. @BMEduard whaddya think?

[BMEduard]

I think this is a question for UX, @AmyYLee what do you think?

[AmyYLee]

I think this is a question for UX, @AmyYLee what do you think?

Do you mean subtext in the private browsing home screen when the user has no tabs opened? Asking @betsymi for her input.

[Poopooracoocoo]

@AmyYLee no a subtext of the disable screenshot option that tells users that Fenix's content will be hidden in the app switcher

[AmyYLee]

@AmyYLee no a subtext of the disable screenshot option that tells users that Fenix's content will be hidden in the app switcher

@Poopooracoocoo Can you post the screen of what you are referring to?

[Poopooracoocoo]

@AmyYLee

The "Allow screenshots in private browsing" option should also include a description that tells users that it also hides Firefox's content in the app switcher.

[Mugurell]

Closing as per https://github.com/mozilla-mobile/fenix/issues/2768#issuecomment-610921742