Fenix: FNX-5522 ⁃ [Bug] Display landscape app menu from bottom

[topotropic]

Steps to reproduce

Go to landscape, open site, open menu

Expected behavior

I see the bottom area of the menu to navigate back or reload

Actual behavior

I don't see the back/reload options and have to scroll down to get to it

[sblatz]

This is another a-c dependent issue

@vesta0, @bifleming

[softvision-miralobontiu]

This is not fixed yet, the menu is displayed from the top.
Tested with the latest build 1.0.1924 (#11620622), on Motorola Nexus 6 (Android 7.1.1), OnePlus 5T (Android 9), and Samsung Galaxy S8 (Android 9).

[sblatz]

This shouldn't have been moved to QA needed just yet. The fix just landed this morning. It should be fixed in tomorrow's nightly.

[Amejia481]

@sblatz After the new snapshot is available, there is minimal work to be done in Fenix, before this issue is fixed :)

We need to add:

    override val menuBuilder by lazy { BrowserMenuBuilder(
        items = menuItems,
        endOfMenuAlwaysVisible = true
    ) }

To DefaultToolbarMenu.kt
https://github.com/mozilla-mobile/fenix/blob/7c37f77cfc0e2ec950540b3b98f4bc9220b836c2/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt#L27

[sblatz]

Awesome, I'll make sure to add this. Thanks @Amejia481

[softvision-miralobontiu]

This is not fixed yet on Android 5 & 6 devices, on the latest build 1.0.1924 (#11640609).
On Nexus 5 (Android 6.0.1), Huawei P9 Lite (Android 6), and Xiaomi Mi4i (Android 5.0.2) the menu is displayed like this:

On Android > 6 it is fixed. Tested on Google Pixel 3 (Android 9), OnePlus 5T (Android 9), Motorola Nexus 6 (Android 7.1.1), Motorola Moto G6 (Android 8).

[vesta0]

I am removing MVP blocker since this is only impacting Android 5 & 6 devices.

[sblatz]

This is also only broken in landscape now, too, @vesta0. So definitely doesn't feel like an MVP blocker. That being said @Amejia481 is close to a fix for these issues :) (and it should remain blocked until he makes the appropriate a-c changes)

[sblatz]

Looks like @Amejia481 just got this fix merged into A-C. It should be fixed on the nightly!

[AndiAJ]

Hi, I'm still able to reproduce this issue on the latest Fenix build (1.0.1926 Build #11780608from 27/6) on the following devices:

• Samsung Galaxy J7 (Android 6.0.1)

• Sony Xperia Z3 (Android 5.1.1)

Based on this I'll remove the "QA needed" label.

[Amejia481]

This change is not part of the snapshot yet.

[sblatz]

My bad, I got a little trigger happy with the "QA Needed" label. I will add it this evening when it's in the snapshot :)

[AndiAJ]

Hi, verified as fixed on the latest Fenix build (#11790617 from 28/6) using the following devices:

• Google Pixel 3XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7.0)
• Samsung Galaxy J7 (Android 6.0.1) Picture
• Sony Xperia Z3 (Android 5.1.1) Picture