Fenix: FNX-499 ⁃ When launching Fenix, Enable private browsing button is focused instead of Search or address

[asadotzler]

Steps to reproduce

Launch Fenix

Expected behavior

Search or enter address is focused

Actual behavior

Enable private browsing button is focused

Device information

• Android device: ? Galaxy S6
• Fenix version: ? Firefox Preview 1.0.1918 (Build #11181249 68.0a1-20190422094240)

[asadotzler]

Would love to get this but we'd probably ship without it.

[fobo66]

I'd like to work on this. Found a root cause, preparing a fix now

[chiragmantri]

@asadotzler is this issue fixed? or is there any work item left for this?

[fobo66]

I've fixed this, it appears to be working fine now

[sv-ohorvath]

Partially fixed. I logged a follow-up bug since this one has already landed in RC 1.2: https://github.com/mozilla-mobile/fenix/issues/4447.

[mcarare]

The fix also causes #4489, I think it should be revisited. Also, IMO the focus change is against good practices in accessibility.

[ekager]

I'm going to undo these changes because it seems to cause other issues (#4447 and #4489), so let's reopen this and we can bring it up as an accessibility concern about the homescreen.

[fobo66]

Looks like this issue cannot be properly fixed (without accessibility focus change) because of homescreen layout hierarchy

[ekager]

Adding a note to investigate setTraversalBefore if we decide we want to change the focus here (and if homescreen layout doesn't change to make this irrelevant)

[lime124]

oops forgot to remove needs ux label - i've added it to an a11y audit so we can look at this then.

[mcarare]

This is fixed, as a result of the changes implemented as per comment: https://github.com/mozilla-mobile/fenix/issues/1718#issuecomment-566674558.