Fec-cms: Test React 16 upgrade due on 9/6/2018

[patphongs]

React 16 is now on the feature environment (https://fec-feature-cms.app.cloud.gov/). Please make sure that it is tested thoroughly by Thursday 9/6/2018, this will give us time to address any critical issues. Deploy to production will be on 9/11/2018. Any problems from the upgrade, please note within this ticket.

• [x] AO Search datatable page: https://fec-feature-cms.app.cloud.gov/data/legal/search/advisory-opinions/. Make sure all filter components work
  
  
  
  • [x] AO Number
  
  
  • [x] Requestor Name
  
  
  • [x] Requestor type
  
  
  • [x] Keywords
  
  
  • [x] More keyword options (Advanced search)
  
  
  • [x] Show only pending requests checkbox
  
  
  • [x] Final Opinion checkbox
  
  
  • [x] votes checkbox
  
  
  • [x] draft docs checkbox
  
  
  • [x] AO Request, Supplemental Material, and Extensions of Time checkbox
  
  
  • [x] Withdrawl Request checkbox
  
  
  • [x] Comments and Ex parte Communications checkbox
  
  
  • [x] Commissioner Statements checkbox
  
  
  • [x] Show cases citing any of them, Show cases citing all of them radio buttons
  
  
  • [x] Regulatory citation
  
  
  • [x] Statutory citation
  
  
  • [x] Issued Date
  
  
  • [x] Request Date
  
  
  • [x] Entity name
  
  
• [x] Make sure that the AO canonical page displays correctly and works https://fec-feature-cms.app.cloud.gov/data/legal/advisory-opinions/2018-10/

[dorothyyeager]

We've got a few Information Division staffers (Paul, Chris and Don) who will test this for us. Am sending them this checklist now. Editing to note that Paul's got a github account so he'll post comments in here and I'll post for those who don't have the github account.

[prstoetzer]

The first thing I note is that the search interface does not load at all in Internet Explorer.

[prstoetzer]

Completed the checklist. The only problem I noted, other than the Internet Explorer compatibility problem, is filtering by a statutory citation. When attempting to filter by a statutory citation, the search process never completes (or takes longer than 2 minutes to do so, I did not wait beyond 2 minutes).

[dorothyyeager]

From Chris (who tested using Firefox): _I was able to complete the checklist with only one issue: the statutory citation filter doesn’t return any results for citations I know are referenced in a number of advisory opinions (30143 for example)._

Chris is going to test on Safari and Opera as well on Tuesday.

[dorothyyeager]

From Don (who tested using Chrome. Paul tested using Chrome as well.):
_1. The “Statutory citation” search does not populate any results. It stays on the loading screen.

1. The “Entity name” search does not show all possible results.
   Internet Explorer did not work._

[patphongs]

Confirmed that statutory citations filter does not work. This is also a problem in production, which seems to be an API bug, unrelated to React. A bug ticket has been made for this here: https://app.zenhub.com/workspace/o/fecgov/openfec/issues/3271.

[patphongs]

@prstoetzer @dorothyyeager and Chris, thanks for helping to test the AOs. I wanted to follow-up about the AO filters not working in IE. I just tried it on my windows machine and it is working. Are there any errors that you get in IE? Does it just hang?

[prstoetzer]

This is all I see.

[dorothyyeager]

Don sent me a similar screencap to that above - IE is not loading the page for them.

Edited to add I just tried it myself on IE 11. The AO search test link is returning the same screen for me and not loading the page.

[dorothyyeager]

Chris was able to test the pages on Opera and Safari. He only noted the same issue with the Statutory Citations in both browsers, but no other problems. Editing to add that this is what he saw:

_The flag animation showing that the page is “thinking.”_

[dorothyyeager]

I tested too. Here's my notes:

On https://fec-feature-cms.app.cloud.gov/data/legal/search/advisory-opinions/, the search filters work, but maybe not as effectively as they could. Some examples:

• Searching "Al Franken" as requester gave me too many results, and some that were frankly not right. (I did get his AO though).

• I put "114.2(f)" as my keyword and got way too many wacky results. Not sure why. Putting 114.2 into the "citations" search yielded the right AOs, but I couldn't narrow the reg to 114.2(f).

• Searching requester type "corporation" yielded LLCs too. Other types of requester types also seemed to yield too much - "Individual" gave me more than "individuals" for example.

Like everyone, I got the blinking flag with no returns when searching with statutory citation filter, and I got the screencap above showing nothing when I used IE.

No comments from me on https://fec-feature-cms.app.cloud.gov/data/legal/advisory-opinions/2018-10/. That seemed to be fine.

[llienfec]

@patphongs - Confirming that search results do not show up for the AO search when using IE 11. Also confirmed that the AO filter is currently working on IE 11 in production.

Let me know if you'd like me to show you or if you need me to look at anything else.

[patphongs]

@apburnes Is going to try a polyfill to fix this issue, will update this ticket again when that has been implemented so that content can test these pages again in IE.

https://reactjs.org/docs/javascript-environment-requirements.html

[apburnes]

See #2330

[patphongs]

Fix for statutory citations should be in the upcoming release, it's pending review now: https://github.com/fecgov/openFEC/pull/3363

[llienfec]

Re-tested the AO search showing results in IE browser -- looked good.

[dorothyyeager]

Chris tested on IE and here are his notes:
_One small issue I just noticed is that the requestor name field is finicky. When I search for “DSCC,” I get nothing, but when I search “Franken,” it returns “Franken/DSCC.” Other requestor name return without a hitch.

Otherwise, I had no issue other than the statutory citation search_

[dorothyyeager]

I just tested in IE11 post-fix and it did load quickly so @apburnes fix worked for IE11!

Some additional comments on the search in general.

• [ ] Not sure the requestor search is working well. It is working, but the results are very mixed. Some examples:

• AO 2008-06 and AO 2001-11 both were filed by the Democratic Party of Virginia, but AO 2008-06 comes up as "Virginia Democrats". So if you search "Virginia" in the AO requester field, they both come up. A search for "Democratic" and "Virginia" brought up both of them plus a lot of other party AOs.

• Searched for DSCC in requestor name after reading Chris' comment. I should have had several results but got none. I did get the desired results when I put "Democratic Senatorial Campaign Committee" in as a keyword using all of the above words. But it should have come up with the requestor name.

• [ ] Requester type still has the issues I noted above although I notice the LLCs in corporation have "includes LLC treated as corporation" added to the filter name which is good.

• [ ] Keyword still has the issues I mentioned. I tried "facilitation" and got too many irrelevant results.

[patphongs]

Testing has been completed. IE 11 issue is fixed with Polyfill and the statutory citations filter is now working in the staging environment, that fix will be deployed on 9/11.

Any outstanding issues that seemed to be unrelated to the react upgrade have been logged within this issue for further analysis: https://github.com/fecgov/fec-cms/issues/2335