Hi @valyala
In Go 1.8, net/http is having graceful shutdown feature. Server.Shutdown
It would be nice if it is implemented in fasthttp too.
arafath-mk
All 25 comments
I'm facing the same issue can we have method to shutdown fasthttp, or ListenAndServe could return the listner object as net/http. We are blocked on this.
uswami
on 20 Mar 2017
I would like to second this. An ability to gracefully shutdown the server would be great. I'm working on a program that could greatly benefit from this.
I would be willing to work on a pull request to enable this, however I would feel more comfortable doing that after some discussion. @valyala and everyone who wants this, should this feature work similar to how net/http accomplishes this in 1.8? Or would that not fit well into this project's codebase? If not, lets discuss a good API design for shutting down servers.
KayoticSully
on 29 Mar 2017
Hi guys, looks like solution already exists: https://github.com/valyala/fasthttp/issues/66
arbrix
on 12 Apr 2017
@valyala I think there is a legitimate need for this instead of people having to write custom listener.
nikunjy
on 26 Apr 2017
+1
briankang
on 2 May 2017
+1
JefferyWang
on 21 Jun 2017
+1
rpcavaco
on 4 Oct 2017
+1
funlake
on 23 Nov 2017
+1
On Thu, Nov 23, 2017 at 5:06 PM, funlake notifications@github.com wrote:
+1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/valyala/fasthttp/issues/233#issuecomment-346562475,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC55hpRgtKgWoiEGIgKb62RE3ecPK1Bks5s5TWHgaJpZM4MFz0S
.
--
Simple forum in golang https://www.youbbs.org
ego008
on 23 Nov 2017
+1
stgleb
on 18 Dec 2017
It would be really nice since Cntrl+C is archaic!
concatime
on 7 Jan 2018
+1
dgrr
on 7 Jan 2018
+1
drunkday
on 11 Jan 2018
+1
ccsnake
on 31 Jan 2018
+1
omriharel
on 8 Feb 2018
+1
mochi-co
on 26 Feb 2018
+1
ilanyu
on 23 Mar 2018
+1
ikozinov
on 13 Apr 2018
Here is an example I wrote. Feedback wanted and welcome:
https://github.com/dstroot/fasthttp-graceful-shutdown
dstroot
on 27 May 2018
+1
thomasxnguy
on 15 Jun 2018
+1
tebeka
on 21 Jun 2018
Because of popular demand I have just added a Server.Shutdown() function to my active fork of fasthttp: https://github.com/erikdubbelboer/fasthttp
erikdubbelboer
on 23 Jun 2018
@erikdubbelboer That's exciting! Deserves a new tag IMO.
Is it a deliberate decision to not take cancellation context?
illotum
on 25 Jun 2018
@illotum I just tagged v1.1.0.
Nothing uses or accepts contexts in fasthttp at the moment. I though it would be weird to only add it to this function. I guess one day someone will make ...WithContext function variants for most fasthttp functions.
erikdubbelboer
on 25 Jun 2018
This was fixed in https://github.com/valyala/fasthttp/commit/e3d61d58fd2466abb8e78f26fb05b1a8df4e9218
erikdubbelboer
on 26 Aug 2018
Related issues
danilobuiatti
·
3Comments
imgurbot12
·
5Comments
kirillDanshin
·
5Comments
facundomedica
·
4Comments
mayocream
·
3Comments
Most helpful comment
@valyala I think there is a legitimate need for this instead of people having to write custom listener.