We somehow managed to go from 7mln rps to 4mln rps.
That must have an urgent fix.
For some more details, see https://github.com/TechEmpower/FrameworkBenchmarks/issues/4410
kirillDanshin
All 5 comments
The last commit before 2018-10-30 was https://github.com/valyala/fasthttp/commit/afcef43292699fa1c35646db8e6423bc4417d4b3. I have been running benchmarks for the last couple of hours now comparing the performance of this commit against the performance of master and I can't see any difference so far. I'm thinking something went wrong when they ran their benchmark.
erikdubbelboer
on 6 Feb 2019
Looking at their history, https://tfb-status.techempower.com/ It looks like the drop in performance happened between Dec 3 and Dec 14. On Dec 3 the performance was 6.6 mil after it was dropped to 4.5. There are two commits during that time. Can any of those be related?
Crypto-PC
on 6 Feb 2019
@philcaetano
Can any of those be related?
No those commits have nothing to do with performance. Neither do any of the commits before or after that.
erikdubbelboer
on 8 Feb 2019
I finally found the issue and fixed it in https://github.com/valyala/fasthttp/commit/02b7301203131adee3b9a91249db9c24da669f6d 馃嵕
erikdubbelboer
on 12 Feb 2019
That was fast!
Hope to see Go at the top 3 again, thanks to fasthttp contributors! 馃殌
ww9
on 12 Feb 2019
Related issues
facundomedica
路
4Comments
imgurbot12
路
5Comments
bullardla
路
5Comments
ohenepee
路
4Comments
unisqu
路
4Comments
Most helpful comment
I finally found the issue and fixed it in https://github.com/valyala/fasthttp/commit/02b7301203131adee3b9a91249db9c24da669f6d 馃嵕