Due to the historical baggage associated with this name I am suggesting we remove the name Adolf from Name.first_name. I was preparing demo for a client today and fortunately caught this name before they saw it.
jstoebel
All 8 comments
see PR 789
jstoebel
on 10 Jan 2017
My second name is Adolfo and my father's second name was Adolfo as well, this PR is not only offensive but also pretty ridiculous.
I'm not ashamed of who I am or what my parents chose to call me, please leave the name as it is and focus your energy in something more productive.
git2samus
on 12 Jan 2017
While I'm glad you're not ashamed of your name, I'm curious to know why this suggestion was deemed "ridiculous." What about wanting to avoid upsetting a paying client with a reference to arguably the most famous mass murderer in history is, to cite the dictionary definition, "deserving or inviting derision or mockery"?
geeksam
on 12 Jan 2017
Because @geeksam a name alone does not identify a person, a full name does and even in that case there are plenty of duplicates.
A name is just a term, it does not have "baggage" and can be used to refer to literally millions of different people.
This wouldn't be as ridiculous (but still pretty useless) if we were taking about surnames but again, anything other than "Adolf Hitler" should be ok.
And keep in mind that every single community out there might have their own despicable historic figure they don't want to be named, it's a really bad rabbit hole to fall into.
git2samus
on 14 Jan 2017
geeksam
on 14 Jan 2017
Shall I submit a PR to add more names of famous dictators, then? Who doesn't love Kruschchev, Todo, Mussolini, Idi, Mao, Saddam, al-Gaddafi, Castro, Franco, Stalin, or Trump?
geeksam
on 14 Jan 2017
Ok, I think we've had a chance for people to make their points on both sides of this issue, so I suggest we end the conversation here.
I closed the issue because I'm not going to spend my time dealing with one-off PRs that change the data for minority use-cases. If there is data in Faker that you don't want to use for whatever reason, all you need to do is override the locale file.
stympy
on 14 Jan 2017
That's actually a cool feature I did not know about. Thanks, @stympy.
geeksam
on 16 Jan 2017
Related issues
SylarRuby
路
3Comments
lassiter
路
3Comments
ggrillone
路
6Comments
kevgathuku
路
4Comments
mhutter
路
5Comments
Most helpful comment
Ok, I think we've had a chance for people to make their points on both sides of this issue, so I suggest we end the conversation here.
I closed the issue because I'm not going to spend my time dealing with one-off PRs that change the data for minority use-cases. If there is data in Faker that you don't want to use for whatever reason, all you need to do is override the locale file.