Faker: `Faker::Number.number` generates numbers that are too long

Created on 15 Dec 2013  路  5Comments  路  Source: faker-ruby/faker

Example output:

>> require 'faker'
=> true
>> Faker::Number.number(9)
=> "1077253297"
>> Faker::Number.number(9).length
=> 10
picture mhutter

Most helpful comment

This can be closed since the PR is merged.

picture tejasbubane on 15 Feb 2016
👍3

All 5 comments

+1 and it looks like @mhutter has the right fix.

taelor picture taelor on 8 Jan 2014

I actually closed the PR after I realized there are already #147 #151 and #156 xD

But the bug is still open...

mhutter picture mhutter on 8 Jan 2014

Hmmm, which PR you think is best?

https://github.com/rdallasgray/faker/commit/4b337302098e40172bb0f22d7ca319db1601ac19

?

taelor picture taelor on 8 Jan 2014

Actually https://github.com/mlawrie/faker/commit/010ae019128a5212c2e7e8706e6137930887b134 because it removes some redundancy and the tests are pretty nice

mhutter picture mhutter on 8 Jan 2014

This can be closed since the PR is merged.

tejasbubane picture tejasbubane on 15 Feb 2016
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lassiter picture lassiter  路  3Comments
KelseyDH picture KelseyDH  路  4Comments
gerryhd picture gerryhd  路  3Comments
tagliala picture tagliala  路  5Comments
CJAdeszko picture CJAdeszko  路  6Comments