Facebook-ios-sdk: Feature Request: Suppress advertiserIDCollectionEnabledFalseWarning

Created on 16 Oct 2019  路  6Comments  路  Source: facebook/facebook-ios-sdk

Checklist

  • [x] I've updated to the latest released version of the SDK
  • [x] I've searched for existing feature requests on GitHub issues
  • [x] I've read the Code of Conduct
  • [x] I've given my issue the title: Feature Request: [name of my feature request]

Goals

As a consumer of the Facebook SDKs purely for social login purposes, I don't want to be notified about unrelated configuration warnings in the console logs during development of my application.

Since we have no need for Facebook to track analytics, we've set the FacebookAdvertiserIDCollectionEnabled and FacebookAutoLogAppEventsEnabled info plist keys to false however we now get the following log message:

<Warning>: The value for FacebookAdvertiserIDCollectionEnabled is currently set to FALSE so you're sending app events without collecting Advertiser ID. This can affect the quality of your advertising and analytics results.

Expected Results

The log message above is not printed in my console. I explicitly opted out of any kind of automatic tracking and I don't need to be reminded about it each time we build and run the application.

If you're happy for me to, I'd be more than happy to submit a PR removing it but I'll wait for a response here first. Thanks

enhancement

Most helpful comment

The log states the following:

so you're sending app events

But the code in FBSDKSettings is only checking isAdvertiserIDCollectionEnabled... Its wrong to assume that I'm sending events when isAdvertiserIDCollectionEnabled is false so maybe this is a bug... Could it not just log in the event that the user tries to track an event with this disabled?

All 6 comments

The log states the following:

so you're sending app events

But the code in FBSDKSettings is only checking isAdvertiserIDCollectionEnabled... Its wrong to assume that I'm sending events when isAdvertiserIDCollectionEnabled is false so maybe this is a bug... Could it not just log in the event that the user tries to track an event with this disabled?

Thanks for submitting this request. We will add it to our feature request list.

The complete sentence is so you're sending app events without collecting Advertiser ID. The flag isAdvertiserIDCollectionEnabled only controls whether you will send app events WITH advertiser id to Facebook, rather than control whether you send app events.

So now in iOS 14 setAdvertiserTrackingEnabled is there. how is that difference than isAdvertiserIDCollectionEnabled?

Any updates on this feature request? I would like this removed from my console as well.

@tianqibt my understanding is no difference. It's the same thing.

But I may be wrong :)

Was this page helpful?
0 / 5 - 0 ratings