Facebook-ios-sdk: Cannot login with Facebook on iOS 13

Created on 13 Sep 2019 · 7Comments · Source: facebook/facebook-ios-sdk

Checklist

[x] I've updated to the latest released version of the SDK
[x] I've searched for existing GitHub issues
[x] I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
[x] I've read the Code of Conduct
[x] This issue is not security related and can safely be disclosed publicly on GitHub

Environment

Xcode Version: Version 11.0 (11A419c)
Swift Version: 5.0 (if issue is Swift related)
Installation Platform & Verison: [Cocoapods] version 5.5.0

Goals

I want users to be able to login to facebook on our app from a webview in iOS 13.

Expected Results

I expect a webview to open after users click on 'continue' when he is asked to sign in with facebook where they can log in with facebook on ios13.

Actual Results

Nothing happens after i click the continue button. No popup or webview opens

Steps to Reproduce

Call the facebook login functionality with LoginManager().logIn(permissions: permissions, from: presenter) { (result, error)

Code Samples & Details

import FBSDKLoginKit

class FacebookService: FacebookServiceProtocol {
    func authorize(permissions: [String], success: @escaping (String?) -> Void, failure: @escaping () -> Void) {
        guard let presenter = UIApplication.shared.rootViewController?.navController?.presentedViewController else {
            failure()
            return
        }

        LoginManager().logIn(permissions: permissions, from: presenter) { (result, error) in
            guard error == nil,
                let result = result, !result.isCancelled,
                let tokenString = result.token?.tokenString else {
                    LoginManager().logOut()
                    failure()

                    return
            }

            success(tokenString)
        }
    }
}

Source

Meilu

Most helpful comment

Not sure if the earlier issue is the same but my new apps broke with iOS 13 projects due to the scene delegate and the fix was pretty simple as per the following post https://github.com/facebook/facebook-ios-sdk/issues/1067#issuecomment-559629930:

See my post here for the solution to this - its pretty simple: https://github.com/facebook/facebook-ios-sdk/issues/1067#issuecomment-559629930

With the latest SDK, this does work fine if you are at NOT using SceneDelegate.

If you are using sceneDelegate the the following AppDelegate method is not called and therefore the login cannot be handled.
func application(_ application: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
    let handled = ApplicationDelegate.shared.application(
        application,
        open: url,
        sourceApplication: options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String,
        annotation: options[UIApplication.OpenURLOptionsKey.annotation])
    return handled
}
This is because, this method is (understandably) deferred to the following method in the SceneDelegate:
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
    ...
}
The solution which I can confirm as working for iOS 13 applications implementing a SceneDelegate is:
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
    guard let url = URLContexts.first?.url else {
        return
    }
    let _ = ApplicationDelegate.shared.application(
        UIApplication.shared,
        open: url,
        sourceApplication: nil,
        annotation: [UIApplication.OpenURLOptionsKey.annotation])        
}

Sagar-AppLogics on 29 Nov 2019

❤2

All 7 comments

Hi @Meilu , did you create the project via Xcode 11? If so, most likely this is duplicate to https://github.com/facebook/facebook-objc-sdk/issues/1043, which we'll fix in next release this week.

dreamolight on 13 Sep 2019

We've released 5.6.0 with support for multi-window apps, please let us know if you could still see this issue.

dreamolight on 14 Sep 2019

This bug still appears for me even when I updated to 5.6.0

HristiyanZahariev on 16 Sep 2019

👍2

Still even in 5.7.0. Please reopen this is quite urgent.

arbitur on 2 Oct 2019

I am facing same issue in 5.7.0. Please reopen it.

shoaib-akhtar on 7 Oct 2019

See my post here for the solution to this - its pretty simple: https://github.com/facebook/facebook-ios-sdk/issues/1067#issuecomment-559629930

With the latest SDK, this does work fine if you are at NOT using SceneDelegate.

If you are using sceneDelegate the the following AppDelegate method is not called and therefore the login cannot be handled.
func application(_ application: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
    let handled = ApplicationDelegate.shared.application(
        application,
        open: url,
        sourceApplication: options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String,
        annotation: options[UIApplication.OpenURLOptionsKey.annotation])
    return handled
}
This is because, this method is (understandably) deferred to the following method in the SceneDelegate:
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
    ...
}
The solution which I can confirm as working for iOS 13 applications implementing a SceneDelegate is:
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
    guard let url = URLContexts.first?.url else {
        return
    }
    let _ = ApplicationDelegate.shared.application(
        UIApplication.shared,
        open: url,
        sourceApplication: nil,
        annotation: [UIApplication.OpenURLOptionsKey.annotation])        
}