External-dns: Add Support for AAAA Records

[lareeth]

I have just added ipv6 support in https://github.com/coreos/alb-ingress-controller and would like to be able to automate adding AAAA records to Route 53, and other providers in the future.

I can see in the Route 53 we currently set the record to be an A record using the RRTypeA

https://github.com/kubernetes-incubator/external-dns/blob/2319a44fc1242e2598cc3e53898e76b9f45b3c52/provider/aws.go#L379

However the AWS SDK also includes the type RRTypeAaaa

https://github.com/aws/aws-sdk-go/blob/b72688f15ec0b32551a50dceeeb2bd53f2e0d690/service/route53/api.go#L14804

Could we just add a new annotation for ipv6 support, and in the isAWSLoadBalancer check, we check if the annotation is set, and then also add/modify an AAAA record. Or do we add the record type as a new parameter of the newChange function, do the annotation check there, and then manage AAAA and A records separately. What about ingress controllers that already have annotations that add ipv6 support to those, for instance alb.ingress.kubernetes.io/ip-address-type for the https://github.com/coreos/alb-ingress-controller ingress controller.

I'm happy to create a pull request with these changes, just want to understand the approach that would like to be made here.

[hjacobs]

@lareeth IPv6 support sounds great! I'm not an expert on how to approach it for AWS, but would like to see IPv6 support :smile:

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[pinepain]

Does anybody found a solution for IPv6 support or working on one?

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.