Express: jade and transformers are deprecated

[bhvreddy]

npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug
instead of jade
npm WARN deprecated [email protected]: Deprecated, use jstransformer

[dougwilson]

Rewriting the examples that use jade to use something else like pug would be a great first pull request :) !

[notrab]

I forgot to comment here earlier but I created a PR which converts all of the Jade templates to Pug and will resolve the issue you posted 🤘

[strugee]

@dougwilson might want to create a "good first pr"/"starter issue"/etc. label for that :)

[dougwilson]

@strugee that is a good suggestion. I just added the "help wanted" label. Do you think that conveys the right ask or think we need a more specific label?

[strugee]

@dougwilson I think that'll be useful. However it might still be a good idea to create a "starter issue" label or something to help more people get involved in the project :)

[samhh]

As a newcomer-ish to open source contributions, that's the label I always look for first. In-fact, that's what I was looking for when I found this!

[Moniarchy]

Looks like there was interest in this. Has this issue been officially claimed/is it being worked on yet? If not, I'd love to take it on.

[dougwilson]

So there are a couple aspects about the issue. The issue itself is basically to somehow get the jade module out of our dev dependencies. The PR #3183 was made to simply completely swap it out to pug, which seemed great at first, but apparently they don't have quite the same Node.js version support we do on the 4.x branch.

I'm thinking that we could probably attack this with a couple iterations:

1. Examples that use jade which have no particular need to use a template at all can just remove template from them (the search example can just be a static page, with search.jade -> public/index.html and client.js -> public/client.js and then use express.static).
2. Examples that use _a_ template engine, but which one doesn't matter can maybe use ejs or something else (?) not fully thought out
3. The "jade" example could either be converted just to pug (which PR #3183 already does) or convert it to a different template engine

I proposed ejs as the "different" engine simply because we already have that one in the dev deps. Other thoughts welcome :)

I hope that helps everyone.

[dougwilson]

And that doesn't have to be one giant PR :) Incremental progress PRs are certainly welcome.

[notrab]

I'm happy to work on your suggestions @dougwilson

Removing Jade examples might be a great way to push forward and reintroduce Pug when the dependencies are settled. ejs is good enough to provide an example of how view engines integrate.

[dougwilson]

Ok, jade has almost been removed through PRs from @notrab 👍

[MeLlamoPablo]

@strugee, I've been lurking repos to see where I could contribute. Node uses the good first contribution tag so that may be cool to use.

[dougwilson]

Yea, the "help wanted" is a default tag from somewhere. I added the "good first contribution" tag now, and even got one done: https://github.com/expressjs/express/issues?utf8=%E2%9C%93&q=is%3Aissue%20label%3A%22good%20first%20contribution%22%20 👍