Eventing: Modify GCP pubsub channel to use CRD

[akashrv]

Problem
Refer to decision made in #1002
This feature request is to update GCP Pubsub channel

There re few more improvement to do while making this change:

• [ ] Move to operator
• [ ] #419 rename to correct external brand name
• [ ] #1125 Should we do this for GCP pubsub channel?
  -[ ] #854 Improve status to correctly propagate channel health

[akashrv]

/milestone v0.7.0

[nachocano]

@Harwayne do you want me to give it a shot at this one?
Or you were planning on working on this for 0.7?

I'm not entirely sure all the changes it entails but I can start looking.

[Harwayne]

/assign @nachocano

Go for it!

[vaikas]

This should also move to messaging.knative.dev as part of that work as per.
https://github.com/knative/eventing/blob/master/docs/decisions/eventing-and-messaging.md

[nachocano]

Sounds good! Will do

On Wed, May 15, 2019 at 12:16 PM Ville Aikas [e-mail]
wrote:

This should also move to messaging.knative.dev as part of that work as
per.

https://github.com/knative/eventing/blob/master/docs/decisions/eventing-and-messaging.md

—
You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub
https://github.com/knative/eventing/issues/1214?email_source=notifications&email_token=ABD65DBFLMDPHDSOAIM74ODPVRORNA5CNFSM4HMGNQJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPVPZQ#issuecomment-492787686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABD65DF7UJ3HSL5COEPHF5TPVRORNANCNFSM4HMGNQJA
.

[nachocano]

@Harwayne @vaikas-google @evankanderson
I'm starting to look at this, and there is this old proposal of also renaming gcppubsub to google-cloud-pubsub or maybe cloud-pubsub. I don't think the latter one is appropriate though. But if we are planning on renaming, this might be the right time.
Would you guys be OK to rename it to google-cloud-pubsub? Or maybe some other name?

[nachocano]

I actually think it would be a good idea to do the renaming. This will make it easier for backwards compatibility with the other provisioner-based one. We mark gcppubsub as deprecated in 0.7, and remove it entirely in 0.8.

[vaikas]

I think google-cloud-pubsub or google-pubsub would be good. cloud-pubsub seems not clear enough.

[akashrv]

google-cloud-pubsub aligns with the brand name.

On Wed, May 15, 2019 at 5:33 PM Ville Aikas [e-mail]
wrote:

I think google-cloud-pubsub or google-pubsub would be good. cloud-pubsub
seems not clear enough.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/knative/eventing/issues/1214?email_source=notifications&email_token=AKYQBFCHMZQFUAC5BEVKTHTPVSTXJA5CNFSM4HMGNQJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQKE4Q#issuecomment-492872306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYQBFERW2ZHG6RTKT5A6C3PVSTXJANCNFSM4HMGNQJA
.

--
Regards,
Akash

[nachocano]

Cool! I already started the code with that one. google-cloud-pubsub it is!

On Wed, May 15, 2019 at 8:05 PM Akash Verenkar [e-mail]
wrote:

google-cloud-pubsub aligns with the brand name.

On Wed, May 15, 2019 at 5:33 PM Ville Aikas [e-mail]
wrote:

I think google-cloud-pubsub or google-pubsub would be good. cloud-pubsub
seems not clear enough.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/knative/eventing/issues/1214?email_source=notifications&email_token=AKYQBFCHMZQFUAC5BEVKTHTPVSTXJA5CNFSM4HMGNQJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQKE4Q#issuecomment-492872306
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AKYQBFERW2ZHG6RTKT5A6C3PVSTXJANCNFSM4HMGNQJA

.

--
Regards,
Akash

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/knative/eventing/issues/1214?email_source=notifications&email_token=ABD65DAPETNTBUOE3PP4WWLPVTFRHA5CNFSM4HMGNQJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQQT6I#issuecomment-492898809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABD65DCE6UW3BEL3324SAELPVTFRHANCNFSM4HMGNQJA
.

[nachocano]

Stopping this as @n3wscott wants to drive it outside our knative-eventing repo. Go for it!

[nachocano]

/assign @n3wscott

[nachocano]

/unassign @nachocano

[sebgoa]

I am looking forward to see this. This should be "multi-tenant" in the sense that a user with no privilege in knative-* namespaces should be able to use this CRD in his/her own namespace using a private service account key and project.

[grantr]

This is being worked on in the https://github.com/google/cloud-run-events repo, but it's not ready yet.

/milestone v0.8.0

[adrcunha]

/milestone v0.7.0

[knative-prow-robot]

@adrcunha: You must be a member of the knative/knative-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v0.7.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sebgoa]

This is being worked on in the https://github.com/google/cloud-run-events repo, but it's not ready yet.

I assume this is a private repo , it gives a 404 !!

[Harwayne]

This is being worked on in the https://github.com/google/cloud-run-events repo, but it's not ready yet.

I assume this is a private repo , it gives a 404 !!

Sorry, typo in the repo name. The correct one is: https://github.com/GoogleCloudPlatform/cloud-run-events

[n3wscott]

fixed by https://github.com/GoogleCloudPlatform/cloud-run-events/pull/26

[n3wscott]

/close

[knative-prow-robot]

@n3wscott: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.