Ethers.js: v5 ContractFactory.deploy() ignores transaction overrides

[pyggie]

In ethers-v5 a deployment transaction such as factory.deploy({ gasPrice, gasLimit }) ignores the transaction overrides. I think the problem is in resolveAddresses() called from here:
https://github.com/ethers-io/ethers.js/blob/db604aa6afc007f8198fc730b7db4f9ae3876c58/packages/contracts/src.ts/index.ts#L982-L983
https://github.com/ethers-io/ethers.js/blob/db604aa6afc007f8198fc730b7db4f9ae3876c58/packages/contracts/src.ts/index.ts#L84-L91
which maps on paramType = this.interface.deploy.inputs = [] and so returns nothing.

[ricmoo]

I’ll look into this shortly. Thanks!

[ricmoo]

I've reproduced it and am re-factoring a bit of that code now which should address this issue and clean things up a bit.

[ricmoo]

This should be fixed in 5.0.0-beta.183. Try it out and let me know. :)

[pyggie]

It works!

[ricmoo]

Awesome! :)