Ethers.js: Support for bool type in `utils.solidityKeccak256`

Created on 4 Feb 2018  路  3Comments  路  Source: ethers-io/ethers.js

Looks like the underlying _pack function does not support the Solidity bool type - this would be nice to add.

bug fixed

Most helpful comment

Fixed in [email protected].

Thanks again! :)

All 3 comments

I鈥檓 not at a computer right now, but a quick look at the solidity utility function looks like you are right. This is a bug and I will address is ASAP. Also, I need to check the procedural test cases, because they must be missing bool too.

Thanks!

Travis CI is running against the new test cases now. Once they pass, I will publish to npm.

Fixed in [email protected].

Thanks again! :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Neozaru picture Neozaru  路  3Comments

naddison36 picture naddison36  路  3Comments

rekmarks picture rekmarks  路  3Comments

dagogodboss picture dagogodboss  路  3Comments

zemse picture zemse  路  3Comments