Ethers.js: Why is there no package-lock.json/ yarn.lock file?

Created on 7 Dec 2019  路  4Comments  路  Source: ethers-io/ethers.js

I just forked this project to add a fix for #346 and, while following the instructions to bootstrap the monorepo, I noticed a package-lock.json got created. This file is neither in version control or gitignor-ed.

Why?

picture paulrberg

Most helpful comment

I haven鈥檛 added it yet, but the CI testing on CircleCI is almost working, at which point I鈥檒l add it. :)

You can probably find it on @yuetloo 鈥榮 fork of ethers. She has been working on most of the CI migration. :)

picture ricmoo on 8 Dec 2019
👍2

All 4 comments

In version 4 (master) or version 5 (ethers-v5-beta)?

Version 4 has one - https://github.com/ethers-io/ethers.js/blob/master/package-lock.json

So you probably mean in v5? Agreed that v5 needs one.

pcowgill picture pcowgill on 7 Dec 2019

Yeah v5, on the ethers-v5-beta branch. The latest commit: https://github.com/ethers-io/ethers.js/commit/9c78c7fee69d07733048d898d58205ae7f5c82d7

Maybe @ricmoo put package-lock.json in his global gitignore 馃

paulrberg picture paulrberg on 8 Dec 2019
👍1

I haven鈥檛 added it yet, but the CI testing on CircleCI is almost working, at which point I鈥檒l add it. :)

You can probably find it on @yuetloo 鈥榮 fork of ethers. She has been working on most of the CI migration. :)

ricmoo picture ricmoo on 8 Dec 2019
👍2

There is now a package-lock.json file along with the CircleCI integration.

:)

ricmoo picture ricmoo on 15 Dec 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

adamdossa picture adamdossa  路  3Comments
crazyrabbitLTC picture crazyrabbitLTC  路  3Comments
ricmoo picture ricmoo  路  3Comments
bbarton picture bbarton  路  3Comments
naddison36 picture naddison36  路  3Comments