Erpnext: GeoLocation not working in V12

[megz2020]

Data is still successfully captured in the GeoLocation field and stored as a Feature Collection in the database, but the marker / shape disappears from the Leaflet map (on the client side) after clicking.

This error occurs in both the developer and production environment of Version 12.

[marynvdl]

Description of the issue

After upgrading to Version 12, the Geolocation field is not showing features on the client-side even though it is captured in the database.

Output of bench version

erpnext 12.3.1
frappe 12.1.0

Steps to reproduce the issue

1. Create a new Location
2. Draw a marker, polyline or polygon
3. Click finish and see how it disappears

Observed result

Stacktrace / full error message

code.js:44 Invalid language option provided for field "Location". Valid options are Javascript, JS, HTML, CSS, Markdown, SCSS, JSON.

[dvdl16]

Same issue for me. Original discussion is here

[revant]

code.js:44 Invalid language option provided for field "Location". Valid options are Javascript, JS, HTML, CSS, Markdown, SCSS, JSON.```

That is a warning message.

It happens when option is not set for Code field. Geolocation field inherits from code field.
put JSON in Options of Geolocation Field. The warning will go away. (won't solve issue)

I can't figure out why the layer vanishes after drawing.

[marynvdl]

Thanks, that makes sense!

Looking at the last commits to geolocation.js, I reverted to before the commit of @netchampfaris, but still same issue.

[revant]

does anyone know how to make the field control full width? like the code/text editor field is?

changing the inheritance of geolocation from code to data solves the problem but it makes the field half width.

frappe.ui.form.ControlGeolocation = frappe.ui.form.ControlData.extend({...

[megz2020]

thanks it's work for me. Apparently, to edit width you should remove input-max-width class from map div.

[megz2020]

i edit input-max-width in frappe-bench/apps/frappe/frappe/public/less/form.less to
// above mobile @media (min-width: 768px) { .layout-main .form-column.col-sm-12 > form > .input-max-width { max-width: 100%; padding-right: 15px; }
and it worked.

[revant]

i edit input-max-width in frappe-bench/apps/frappe/frappe/public/less/form.less to

I don't think that is the right way. I sent a PR to make the field working again, did not set the width by editing form.less

[revant]

For reference

does anyone know how to make the field control full width? like the code/text editor field is?

set property horizontal to false

https://github.com/frappe/frappe/pull/9282/commits/039cd2b9207ccf286194295e2a1688c1ef59e400

[marynvdl]

Thanks so much, @revant, it works for me after bench build.