Erpnext: Subscription - Replace Subscriber with Customer master - Deprecate Subscriber master

[umairsy]

Which ever fields are needed in the Subscription master, if at all needed in feature, add in the Customer master itself.

In in the Subscription Plan Details, fetch values from Subscription Plan and show more columns.

[tundebabzy]

Actually we need the Subscriber doctype to capture things that are subscription related as time goes on. For example, users should be able to use coupons in subscriptions. Coupons can added on subscription basis or on subscriber basis. If the user chooses to add a coupon on subscriber basis, Customer doctype doesn't seem the right place to add it. Another potential addition is account balance. Users should be able to view a Subscriber's balance on account without going through the subscriptions. Customer doctype will also not be a good place for it.

Based on that, even though it sounds counter intuitive, Subscriber is essentially different from a customer and it will not be a good idea to deprecate Subscriber for Customer.

[Olawale1]

If the user chooses to add a coupon on subscriber basis, Customer doctype doesn't seem the right place to add it

hi @tundebabzy , why do you say so? I don't see any problem with issuing a coupon to a Customer

Cheers

[umairsy]

Yes, coupons etc. will be issued to Customer only. Let's deprecate Subscriber and use Customer only.

[tundebabzy]

At this point I think I need to reconsider my approach. Perhaps we should
remove the Subscriber doctype and link Subscriptions directly to
Customer.

Added to my to-do list as well

On Fri, 24 Aug 2018, 14:09 Umair Sayed, [e-mail] wrote:

Yes, coupons etc. will be issued to Customer only. Let's deprecate
Subscriber and use Customer only.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/frappe/erpnext/issues/15028#issuecomment-415753737,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAx-c9T2cW13VN-vFvMfT9Lz2M4ODhzgks5uT_sXgaJpZM4VjcO_
.

[Olawale1]

Hi @deepeshgarg007

What's the status of this? Was it done or was it discarded?

Thanks