Enterprise: [Editor] Hyperlinks not clickable when readonly

Created on 21 Dec 2020  路  5Comments  路  Source: infor-design/enterprise

Describe the bug
https://github.com/infor-design/enterprise/pull/4215 seem to have broken the behavior and functionality of Hyperlinks in a read-only editor. The following css (light-theme.css) makes them non-clickable, and the links are indistinguishable
from other text nodes (black color) if it is the first element in the editor. See demo below

.editor-container.is-readonly .editor a {
  pointer-events: none;
}

.editor-container.is-readonly .editor > * {
  color: #1a1a1a !important;
}

Version

  • ids-enterprise: 4.35.0 (but the bug was introduced when we upgraded to 4.33.0)

Screenshots

https://user-images.githubusercontent.com/4991954/102797027-62271b80-43af-11eb-98f8-51d4fe0ee6dd.mov

https://user-images.githubusercontent.com/4991954/102797040-64897580-43af-11eb-9d4e-a5cde60188e7.mov

Platform

  • Infor Application/Team Name: Homepages
  • OS Version: Windows 10, MacOS Big Sur
  • Browser Name: Chrome, Safari

Additional context
https://jira.infor.com/browse/LIME-6575

[2] type

All 5 comments

@ericangeles @tmcconechy The hyperlinks are now clickable in read-only mode (thanks for the fix!). However they still get the wrong format if they are added at the beginning due to this one:

.editor-container.is-readonly .editor > * {
  color: #1a1a1a !important;
}

https://user-images.githubusercontent.com/4991954/103878576-e8916c00-50d6-11eb-861f-5b3764e2e619.mp4

@anhallbe I see. Yeah, I think this should be fix and it can fix quickly. @tmcconechy should we create another issue?

@ericangeles no this is fine, can just do a PR and reference this same issue. Do it on master and i can merge it back into 4.36 if its small

Was this page helpful?
0 / 5 - 0 ratings