Enterprise: Application menu: too much spacing level spacing when icon used in accordion header in uplift theme.

Created on 28 Jul 2020  路  6Comments  路  Source: infor-design/enterprise

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
https://master-enterprise.demo.design.infor.com/components/applicationmenu/test-six-levels-icons.html?theme=uplift&variant=light&colors=0066D4

Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/applicationmenu/test-six-levels-icons.html?theme=uplift&variant=light&colors=0066D4
  1. Switch the Theme to Subtle from More button on the right
  2. Expand the Level 1 with the globe icon
  3. Expand down to level 2 and level 3 to see sub menus
  4. Note the spacing

  5. Now switch the Theme to Vibrant from More button on the right

  6. See how much more spacing is used.

Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: [e.g. chrome, safari, stock browser]
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

Additional context
Add any other context about the problem here.

subtle
vibrant

[3] design high landmark type

All 6 comments

@inforandy could you please look at this with design with a higher priority. Was talking to @kevinwhitedesign and i think this padding should probably be reduced for the levels (maybe to 8pt grid (4s and 8s increments)). This spacing is a bit excessive and causing issues when there are 3-6 levels in common use cases with larger text.

@pwpatton dont think this can make this sprint as it is more complex...

@tmcconechy isn't this just excessive space when an icon is on the first accordion level vs no icon? doesn't seem like the icon should be causing any extra left-padding. Can't we at least just fix that on this ticket and make another ticket if we want other improvements?

@EdwardCoyle after trying it a bit and talking with @EdwardCoyle it's not like one rule. Its a series of rules that makes each level line up, and its accordion and app menu examples and other related things that all need adjusting.

And it is following the original design that the + icon lines up with the text. But it is extra spacious, agreed changes can be made. We just would like design to look at it and come up with a solution that works given this case so we don't have to do this all twice and/or wrong when we just went through changing this not long ago https://github.com/infor-design/enterprise/issues/2925

For now ~ Lets remove the first level indenting to be similar to before.

@kevinwhitedesign we made a change for this see the updated version https://master-enterprise.demo.design.infor.com/components/applicationmenu/test-six-levels-icons.html?theme=uplift&variant=light&colors=0066D4

We just moved it over. Feel free to review and comment if you have any further suggestions

QA Passed on my end. Thank you.

Old Version (Left Side) | Fix (Right Side)
image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jamie-norman picture jamie-norman  路  18Comments

tmcconechy picture tmcconechy  路  25Comments

508it picture 508it  路  33Comments

sanx72 picture sanx72  路  16Comments

Fruko picture Fruko  路  31Comments