Enterprise: Locale: Missing culture property firstDayofWeek

Created on 30 Oct 2019  路  6Comments  路  Source: infor-design/enterprise

90% of culture files are missing firstDayofWeek assignment.

Below is example of where it is provided.
https://github.com/infor-design/enterprise/blob/ded35cb4f7ce13a0d66c2c0f86a764253abc3a1a/src/components/locale/cultures/en-GB.js#L42

Is this something which should be covered 100% across all culture files provided by soho?

[3] type

All 6 comments

It defaults to zero otherwise. But if it鈥檚 needed as part of the data I can understand?

Infor CRM CE noticed this one as the Mongoose calendar correctly shifts the first day of the week based on the culture but the IDS picker does not (we have an internal Jira for this if needed):

image

Is there a mismatch on some of the locales maybe? Being that the default is zero perhaps some are not that should be? Which language is that? Is that Thai?

That is Thai (Thailand): th-TH, the other note there is that they are one of the few that uses a non-Gregorian calendar as well.

I鈥檒l check the first day locales data again against cldr (data source) and see about first day.
We do not currently support Thai calendar only Gregorian and umalqura. Could be added if there is a need for it but that鈥檚 a bigger task. If needed let鈥檚 make a separate ticket with justification for it mentioned.

QA Passed. Will now move to Done.
Verified in http://master-enterprise.demo.design.infor.com/components/datepicker/example-index.html. Thank you.

Was this page helpful?
0 / 5 - 0 ratings