Enterprise: Editor: Uplift causes some editor toolbar buttons to not fully display

[fitzorama]

Describe the bug
When the soho-editor is used with the uplift theme, the H3 and Visual buttons do not fully display.

To Reproduce
Steps to reproduce the behavior:

1. Go to http://localhost:4000/components/editor/example-index.html?theme=uplift&variant=light&colors=0563C2
2. The H3 button does not fully display
3. Click on the HTML button
4. The Visual button does not fully display

Expected behavior
The buttons should fully display

Version

• ids-enterprise: 4.21.0-dev

Screenshots

Platform
All

Additional context

[tmcconechy]

This was fixed in time for 4.21-beta2 on this PR https://github.com/infor-design/enterprise/issues/2541 adding for QA to review again.

[fitzorama]

@tmcconechy After updating this morning, I am still seeing the Visual button being truncated > 4.22.0-dev.

Also can see it here > http://master-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift&variant=light&colors=0563C2

[tmcconechy]

The fix is in the 4.21.x branch, so will be in 4.21. I'll merge this back to the dev branch now so it will work there two next nightly. (I forgot 😞 )

[fitzorama]

It looks like both the beginning and end of the Visual label is being truncated.

[fitzorama]

Ok; great.

[tmcconechy]

Merged to master so check next dev build or 4.21-beta 2 or later. Looks like this:

[tmcconechy]

FYI todays build ran 2 hrs ago so it will be tomorrow around noon for a new dev build

[brianjuan]

http://4210-beta2-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift
http://4210-beta3-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift
"H3" and "Visual" are now not truncated. But when you go back to Soho using ... menu, the issue still happens and you can also notice that icons are still in Uplift and not in Soho.

Steps:

1. Go to http://4210-beta2-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift
2. You'll notice that issue is fixed
   

1. Click ... menu in the header, then select Theme, then Soho
2. See issue still happens
   
   

[tmcconechy]

cc @EdwardCoyle

[EdwardCoyle]

There are different style rules that govern the size of the buttons between Soho and Uplift, so not surprising that it looks strange. The real problem is the Uplift icons in the Soho theme.

@tmcconechy wasn't there a ticket for this same issue scheduled?

[tmcconechy]

Oh, Ok so its just the icons not changing. Ok lets close this for now. That was fixed here https://github.com/infor-design/enterprise/pull/2782

[tmcconechy]

@brianjuan please retest the last point on 4.22 i added it to that board as on 4.22 the icons will change when you switch theme but not on earlier versions than that.

[brianjuan]

Sure, will retest this on 4.22. Thanks @tmcconechy and @EdwardCoyle.

[brianjuan]

Hi, the issue that I've commented still exist in master, http://master-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift. Icons still don't change when you go back to Soho, and HTML/VISUAL are still cropped.

[brianjuan]

http://master-enterprise.demo.design.infor.com/components/editor/example-index.html?theme=uplift
Passed QA testing in all browsers, moving to Done.