Enterprise: Datagrid - tabbing into editable cells of different rows with inlineEditor=true not working correctly

Created on 7 Feb 2019  路  4Comments  路  Source: infor-design/enterprise

We have columns in Datagrids with inlineEditor = true and when we tab through the rows, even though the focus changes, the row is not selected correctly.

This is the SOHO example that has it:
https://latest-enterprise.demo.design.infor.com/examples/saleshub/product-search.html

To Reproduce
Steps to reproduce the behavior:
1) Select the qty cell of say, row1
2) Tab through the cells/rows to say, qty cell of row3
3) Change qty to 8
4) You will notice that it has changed the qty of row1

Expected behavior
Qty of row3 should change to 8

Platform

  • Browser Name [e.g. chrome, IE, safari, stock browser]
  • currently using SOHO version 4.12.1 but seems to be an issue in the latest one too
[2] high type

All 4 comments

From a convo on this with @ShyamaMenon also noting that it may be related to this area:

https://github.com/infor-design/enterprise/blob/master/src/components/datagrid/datagrid.formatters.js#L17

This change breaks tabbing through the actionable grid items.

  1. goto '/components/datagrid/test-editable-actionable-mode.html"
  2. Click on the date cell
  3. use Shift-Tab and Tab to move through the cells within the datagrid

The cells are not inaccessible
image

There needs to be a check to see if the column has an inline editor, so that it is not applied to other columns.

if (key === 9 && self.editor && self.editor.name === 'input' && col.inlineEditor === true) {

@davidcarlsonberg - Can you check this out? Sounds like a reasonable adjustment to me.

Was this page helpful?
0 / 5 - 0 ratings