Enhancements: Kubeadm machine/structured output

[akutz]

Enhancement Description

• Kubeadm support for structured output, such as JSON, YAML, or a Go template
• Kubernetes Enhancement Proposal: KEP
• Primary contact (assignee): @akutz
• Responsible SIGs: SIG-Cluster-Lifecyle
• Enhancement target (which target equals to which milestone):
  
  
  
  • Alpha release target 1.17
  
  
  • Beta release target TBD
  
  
  • Stable release target TBD
  
  
• Related to:
  
  
  
  • https://github.com/kubernetes/kubeadm/issues/494
  
  
  • https://github.com/kubernetes/kubeadm/issues/659
  
  
  • https://github.com/kubernetes/kubeadm/issues/953
  
  
  • https://github.com/kubernetes/kubeadm/issues/972
  
  
  • https://github.com/kubernetes/kubeadm/issues/1454
  
  
• Replaces:
  
  
  
  • https://github.com/kubernetes/kubernetes/pull/75894 (design doc)
  
  

/sig cluster-lifecycle

cc @bart0sh

[kacole2]

@akutz Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

[akutz]

Hi @kacole2,

We are discussing this during today's kubeadm call, and I'll ask for people's thoughts on that there. Thank you!

[timothysc]

Per discussion we're gunna hold for 1.15 and try to settle on the KEP for implementation in 1.16.

[kacole2]

/stage alpha
/milestone v1.16

Hi @akutz, I'm the 1.16 Enhancement Lead. I've added this to the 1.16 Tracking Spreadsheet.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

[neolit123]

@akutz @bart0sh would you have bandwidth for this in 1.16?
let me know so that we can update the tracking.

[bart0sh]

I'm planning to finish this POC https://github.com/kubernetes/kubernetes/pull/78764
We need to decide what to do with the KEP though.

[akutz]

I'd like to manage the PoC via the KEP, but I'm also happy to transfer ownership of the KEP to @bart0sh as I'm now engaged in another activity that doesn't leave me a lot of time for the KEP.

[fabriziopandini]

@neolit123 @kacole2, if I'm not wrong, this issue should be set to tracked yes
/kind feature

[neolit123]

updated -> tracked/yes.

[mrbobbytables]

@akutz @neolit123 @fabriziopandini -- One of the 1.16 enhancement shadows here -- Just as a friendly reminder that the KEP itself must be in an Implementable state by EOD today. It'd also be helpful to update the original issue with links to the KEP directly now that it has been merged.

Thanks!

[neolit123]

thanks for the heads up @mrbobbytables

One of the 1.16 enhancement shadows here -- Just as a friendly reminder that the KEP itself must be in an Implementable

sent PR for that:
https://github.com/kubernetes/enhancements/pull/1188

It'd also be helpful to update the original issue with links to the KEP directly now that it has been merged.

updated.

[neolit123]

UPDATE: as discussed with @timothysc on slack we are not going to track this in 1.16.

[mrbobbytables]

Thanks for the update @neolit123 I'll go ahead and remove it from the tracking sheet 👍

[palnabarun]

Hey there @neolit123 , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[neolit123]

Hey there @neolit123 , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

yes, alpha is the plan for 1.17.
i will update the OP.

[palnabarun]

Thank you @neolit123 for the update.

Just a friendly reminder, in order to have this part of the release:

1. The KEP PR must be merged
2. The KEP must be in an implementable state
3. The KEP must have test plans and graduation criteria.

I see that the attached KEP is in a provisional state. Please make sure that the KEP is in an implementable state before the enhancements freeze on 10/15

[palnabarun]

/milestone v1.17

[neolit123]

@bart0sh please PR the KEP, because its still in provisional state and not implementable.
this has to be changed if you want the feature to be part of 1.17:

https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/sig-cluster-lifecycle/kubeadm/20190506-kubeadm-machine-output.md

[bart0sh]

@neolit123 done, please merge: https://github.com/kubernetes/enhancements/pull/1278

[daminisatya]

Hello, @akutz I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[neolit123]

hi, @daminisatya we are not planning to add any documentation or e2e tests for this feature (alpha in 1.17). the docs will be on the CLI side for kubeadm (via --help) for now.
thanks.

[daminisatya]

Thank you @neolit123 for the quick update!

[palnabarun]

Hi @neolit123

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that https://github.com/kubernetes/kubernetes/pull/78764 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance :smile:

[neolit123]

hi @palnabarun

from my perspective the instrumentation for enabling this is already present for an ALPHA state, we have another pending PR that we want to merge:
https://github.com/kubernetes/kubernetes/pull/83941

[palnabarun]

@neolit123 Thank you for the updates. :) I am adding the PR you mentioned to the tracking sheet.

[palnabarun]

Hi @neolit123 , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PR has not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[neolit123]

@palnabarun hi, given the underlying backend is already in place in kubeadm and also some commands already support the feature "structured output" we are OK to have this feature graduate alpha without the PR https://github.com/kubernetes/kubernetes/pull/83941 merging in 1.17.

[palnabarun]

@neolit123

Ah! Okay. So, shall I remove https://github.com/kubernetes/kubernetes/pull/83941 from 1.17 tracking due to its optional nature and flip the status backed to Tracked?

[neolit123]

Ah! Okay. So, shall I remove kubernetes/kubernetes#83941 from 1.17 tracking due to its optional nature and flip the status backed to Tracked?

yes, seems good to me.

[palnabarun]

Awesome. Thanks! :smile:

[palnabarun]

Hey there @neolit123 -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

• Monday, January 6th - Release Cycle Begins
• Tuesday, January 28th EOD PST - Enhancements Freeze
• Thursday, March 5th, EOD PST - Code Freeze
• Monday, March 16th - Docs must be completed and reviewed
• Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

[fabriziopandini]

@neolit123, considering we are still completing this feature, IMO we should remain alpha also in 1.18. opinions?

[neolit123]

+1

@palnabarun
we are going to continue the work on this feature by merging some PRs, but it will remain alpha for 1.18. the work is tracked here https://github.com/kubernetes/kubeadm/issues/494

[palnabarun]

Thanks @neolit123 for the updates. :)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[neolit123]

/remove-lifecycle stale

[palnabarun]

/milestone clear

(removing this issue from v1.17 milestone as the milestone is complete)

[kikisdeliveryservice]

Hi @neolit123 !

1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

Please let me know and I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[neolit123]

hi, this feature will not graduate to beta in 1.19. thanks.

[kikisdeliveryservice]

@neolit123 thanks for the update!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fabriziopandini]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

[neolit123]

Likely, no. Will update here if we change our plans.