Enhancements: Pass Pod information in CSI calls

[jsafrane]

Feature Description

• One-line feature description (can be used as a release note): CSI driver may opt-in to receive information about Pod that requested a volume in NodePublish request.

• Primary contact (assignee): @jsafrane

• Responsible SIGs: @kubernetes/sig-storage-feature-requests @kubernetes/sig-node-feature-requests
• Design proposal link (community repo): https://github.com/kubernetes/community/pull/2439
• Link to e2e and/or unit tests: TBD
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @gnufied @msau42
• Approver (likely from SIG/area to which feature belongs): @saad-ali
• Feature target (which target equals to which milestone):
  
  
  
  • Alpha release target (x.y): 1.12
  
  
  • Beta release target (x.y): 1.13
  
  
  • Stable release target (x.y): 1.14
  
  

API PRs:

• [ ] https://github.com/kubernetes/kubernetes/pull/73883

Tagging sig-node since it will probably need a new gRPC API in kubelet. Proposal will follow soon. Proposal has been created.

[justaugustus]

Thanks @jsafrane! This has been added to the 1.12 tracking spreadsheet.

/assign @jsafrane
/stage alpha

[zparnold]

Hey there! @jsafrane I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[justaugustus]

@jsafrane --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[msau42]

@childsb @gnufied ^

[kfox1111]

can we pass through volume.Name too? looks like it is already exposed indirectly to the driver by way of the mount path here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/csi/csi_mounter.go#L79
I'd rather use a passed version then parse it out.

[gnufied]

This feature is on track for 1.12. I will open placeholder PR for docs shortly.

@kfox1111 you mean PersistentVolume.Name field?

[justaugustus]

@gnufied -- Please keep us posted. Docs PR is overdue at this point.

[kfox1111]

the pod spec, volume.name. (the name property of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#volume-v1-core)

[kfox1111]

Skimming the code, I think its adding the line: "csi.storage.k8s.io/pod.volumeName": c.specVolumeID,

[tfogo]

Hi @gnufied, do you have an update on the Docs PR? Please let us know as soon as you have a PR open.

[gnufied]

@tfogo now that I think of, traditionally CSI+Kubernetes interface has been documented https://kubernetes-csi.github.io/docs/ rather than on community website. This PR change does not affect any end users and is mostly applicable for CSI plugin authors.

I am wondering if we even need a docs PR to community website. cc @saad-ali

[tfogo]

That makes sense. In that case, it's totally fine not to have a PR open in k/website. (Though you should make sure the appropriate docs land in k-csi/docs.)

[justaugustus]

Thanks for the update!

[saad-ali]

Agreed with @gnufied. This change should be documented in kubernetes-csi as it is relevant to CSI driver authors not end users. Tracking that work here.

[ameukam]

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

[kacole2]

Hi @jsafrane is this enhancement going to graduate to beta in 1.13? Need a confirmation so it can be tracked properly. thanks!

[jsafrane]

Yes, we want beta in 1.13

[kacole2]

/milestone v1.13

[AishSundar]

@jsafrane what work is left for this to land in Beta in 1.13? Is there a list of pending PRs we are tracking for this (code, test and docs)? is https://github.com/kubernetes/community/pull/2273 the only pending PR?

[ameukam]

Hi @jsafrane, I'm Enhancements Shadow for the 1.13 release. As asked by @AishSundar can you please mention the remaining PRs for this enhancement so the Release Team can have a follow up ?

Code slush begins on 11/9 and code freeze is 11/15.

Thank you!

[msau42]

The pending PRs are:

• [ ] E2E test: https://github.com/kubernetes/kubernetes/pull/70439
• [ ] Move CSIDriver object to beta: https://github.com/kubernetes/kubernetes/pull/70367
• [ ] Docs

cc @bertinatto

[AishSundar]

@msau42 @jsafrane we are already in slush and fast approaching Code freeze for 1.13 this friday 11/16. Do you think this feature is still on track for 1.13?

I see both the PRs listed above is active review state and I am more concerned about things splling into freeze. We would like for all pending work to be completed early this week (EOD Wednesday), giving us atleast a couple fo days to watch and stabilize CI. Do you think this is feasible?

[AishSundar]

Also can you plz point us to the draft Docs PR?

[msau42]

cc @wongma7

[msau42]

I just discussed with @saad-ali and @davidz627 and we decided to not move to beta this release, and instead focus on CSI GA.

I've updated this comment above with all the tasks we need to do for beta.

[AishSundar]

@kacole to move this out of tracking for 1.13

@tfogo, @marpaia and @kbarnard10 to remove it from their updates respectively

[kacole2]

/milestone clear

[claurence]

@jsafrane Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I can't find a KEP for this issue can you please share a link for the KEP

[msau42]

We plan to move this feature to beta in 1.14. This feature already has a design proposal. Do we need to convert this into a KEP?

[claurence]

@msau42 Yes please convert to a KEP! Also if there are any open PRs for this issue please link them so we can add to the tracking sheet.

[claurence]

@msau42 checking in on a link to a KEP - have you had a chance to merge the design proposal into a KEP?

[msau42]

/assign @bertinatto

[msau42]

Kep is here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-pod-info-on-mount.md

[makoscafee]

Hey @bertinatto @jsafrane @msau42 👋 I'm the v1.14 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[thockin]

The API PR for this is the same as for https://github.com/kubernetes/enhancements/issues/770 - is that intended? Are these dups, or covering different facets of that PR?

[msau42]

The API changes for #557 #603 #770 and this are all covered by kubernetes/kubernetes#73883.

[liggitt]

The API changes for #557 #603 #770 and this are all covered by kubernetes/kubernetes#73883.

thanks, tracking https://github.com/kubernetes/kubernetes/pull/73883 in https://github.com/orgs/kubernetes/projects/13

[makoscafee]

Hi @thockin, @liggitt just to check again if this issue needs any docs and if needs one have you managed to open docs PR(or a placeholder PR) against dev-1.14 as the deadline for doing so(1 March) is tomorrow.
Thanks

[liggitt]

^ @jsafrane

[msau42]

This feature is not user facing, so no docs are needed for kubernetes.io. We will, however, update developer docs for kubernetes-csi

[makoscafee]

@msau42 Thank you for the information

[jsafrane]

1.14 updates are in progress at https://github.com/kubernetes-csi/docs/pull/121

[claurence]

@jsafrane it looks like k/k PRs for this issue have been merged for 1.14 - are there any additional open PRs for 1.14 that need to be merged for this enhancement?

[msau42]

There is one more PR I am working on to update the tests. I will open one soon

[claurence]

Thanks @msau42! Reminder code freeze is Friday!

[msau42]

e2e pr: https://github.com/kubernetes/kubernetes/pull/74993

[kacole2]

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

[msau42]

This feature will remain in beta for 1.15

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[rbitia]

Hi @jsafrane , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[jsafrane]

No, we're not graduating this feature to GA in 1.16, it stays as Beta.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kacole2]

/reopen
/remove-lifecycle rotten

[k8s-ci-robot]

@kacole2: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

/assign @gnufied

[jeremyrickard]

Hey there @jsafrane @gnufied -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[kfox1111]

I don't know the plan for pod inline csi storage, but it depends on pod info.

[gnufied]

We are tracking this feature to go GA in 1.17. Can we please add this to tracking sheet?

[jeremyrickard]

@gnufied yeah, i'll toggle the status!

[jeremyrickard]

/milestone v1.17

[VineethReddy02]

@gnufied @jsafrane

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

[VineethReddy02]

Hey, @gnufied @jsafrane Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!
We are 5 days away from the deadline. Thanks!

[jeremyrickard]

Hey @gnufied @jsafrane,

:wave: Jeremy from the 1.17 enhancements team here. We're quickly approaching Code Freeze on Nov 14th, so I wanted to check in and see how this was going. We don't currently have any k/k PRs tracked in the enhancements spreadsheet for this graduation. We'll need to track any work up to the code freeze, so if you could please link any in progress PRs here that would be great! I'll get them added to the sheet.

Thanks so much!

[jeremyrickard]

Hey @gnufied @jsafrane just wanted to drop a reminder that we need to have a draft PR for the docs by the end of today. If that isn' open, we'll need to remove this from the 1.17 milestone.

[jeremyrickard]

Hey @gnufied @jsafrane, it seems we missed the docs PR placeholder deadline for this KEP so we'll be removing it from the 1.17 milestone. In order to get this back in the milestone, you'll need to ask the release lead, @guineveresaenger, for an exception.

[jeremyrickard]

/milestone clear

[gnufied]

@jeremyrickard please see comment by @saad-ali https://github.com/kubernetes/enhancements/issues/603#issuecomment-419525702 . This is not a user facing change and no documentation is required in kubernetes/website repo for this change. This will be documented via - https://github.com/kubernetes-csi/docs

[jeremyrickard]

/milestone v1.17

[jeremyrickard]

Thanks for the clarification @gnufied. I’ve added this back to the 1.17 milestone.

[jeremyrickard]

Hi @gnufied @jsafrane tomorrow, 14.11.2019, is code freeze for the 1.17 release cycle. It looks like https://github.com/kubernetes/kubernetes/pull/84814 has not yet been merged. We're flagging as At Risk in the 1.17 Enhancement Tracking Sheet.
Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[jeremyrickard]

Hi @gnufied @jsafrane 👋

Unfortunately, the code freeze deadline has passed and https://github.com/kubernetes/kubernetes/pull/84814 has not been merged, so this enhancement is being removed from the 1.17 milestone. At this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

[jeremyrickard]

/milestone clear

[jeremyrickard]

If you'd like to file an exception, please see here

[helayoty]

Hey @gnufied @jsafrane -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks!

[gnufied]

Since we narrowly missed finishing this in 1.18, we are planning to get this feature done in 1.18. I have updated merged KEPs - #1455

[helayoty]

@gnufied Thanks for the update.

[helayoty]

/milestone v1.18

[irvifa]

Hello @gnufied I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

Hello @gnufied I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

[jeremyrickard]

Hey @gnufied,

For 1.17 it looks like this missed code freeze because https://github.com/kubernetes/kubernetes/pull/84814 didn't merge. It still looks like it has not merged. Are there any other k/k PRs that need to be tracked for this issue? We're about a week out from code freeze, which is on 05 March 2020.

[huffmanca]

@jeremyrickard ,

I'm still working on this PR, and hoping to have it ready for review this week. There are no other k/k PRs to my knowledge regarding this issue.

@irvifa ,

Per https://github.com/kubernetes/enhancements/issues/603#issuecomment-419525702, this is not a user facing change and no documentation is required in kubernetes/website repo for this change. This will be documented via - https://github.com/kubernetes-csi/docs

[msau42]

@huffmanca, we may still need docs on the k8s side for the feature gate.

[VineethReddy02]

Hi @huffmanca @msau42
Does this feature need any user-facing guide under k8s/website? If so please raise a placeholder PR against the dev-1.18 branch. Tomorrow is the deadline. Please raise PR ASAP.

Thanks! :)

[huffmanca]

@VineethReddy02 ,
I've created https://github.com/kubernetes/website/pull/19354 as a placeholder for the doc update.

[irvifa]

@huffmanca Thanks, I've updated the sheet..

[helayoty]

Hey @huffmanca Code freeze is today midnight. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

[huffmanca]

@helayoty ,

It's been reviewed and approved by the storage team, and I've pinged the API reviewer. I'm hoping he'll be able to take a look at it today.

[helayoty]

/milestone clear

[helayoty]

The Code freeze is in effect now. You may need to file an exception.

[jeremyrickard]

/milestone v1.18

The PR for this had appropriate approval and milestone assigned prior to code freeze, so we'll add this back.

[palnabarun]

/close

(closing this since the KEP has been implemented)

[k8s-ci-robot]

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.