Would be great to add a toggle for a dark theme. I'm not a designer not good with colors but would be happy to implement the actual toggle button and behavior.
sotojuan
All 4 comments
Hello @sotojuan! This is something I think a great deal of people would love to have. @burden and myself have discussed this a bit but have never come to a consensus on approach. If you have any thoughts or could point us towards any projects you think might be useful, that would be tremendously helpful!
doomspork
on 21 Jun 2018
@doomspork Let's look at the Phoenix docs for example. You see a little moon sign in the sidebar - click it and dark mode is toggled on. I'm going to assume some JavaScript is doing this in the background.
I can write the code to enable this toggle and push a PR, and then we can bikeshed about what colors to actually use. Sounds good?
sotojuan
on 23 Jun 2018
@sotojuan we haven't forgotten about your request! We'd love your PR if you're still open to opening one. I've been rather busy but I will be working with @burden to identify a way to implement your request if you have not already.
doomspork
on 30 Sep 2018
Thanks to everyone involved into this! The dark theme looks really cool.
I suppose that the issue can be closed since all the changes are already available.
nscyclone
on 19 Oct 2018
Related issues
jaytheking
路
3Comments
ybur-yug
路
4Comments
ukchukx
路
5Comments
nscyclone
路
5Comments
roberthopman
路
3Comments
Most helpful comment
@doomspork Let's look at the Phoenix docs for example. You see a little moon sign in the sidebar - click it and dark mode is toggled on. I'm going to assume some JavaScript is doing this in the background.
I can write the code to enable this toggle and push a PR, and then we can bikeshed about what colors to actually use. Sounds good?