Elixirschool: Should version severity captions in translation reports be translated?

Created on 25 May 2018  路  5Comments  路  Source: elixirschool/elixirschool

The question is pretty simple:


should this

current


look this way?

_using an existing translation for different severity levels:_

proposed_translated

_falling back to English when translation is not available yet:_

proposed_default

Detailed explanation makes more sense than a single word, but repeating descriptions may take a lot of space. WDYT?

Most helpful comment

+1 with detailed.
Plus having patch, none, minor, major in English makes no sense in other languages

All 5 comments

+1 with detailed.
Plus having patch, none, minor, major in English makes no sense in other languages

To be honest with you, I don't like either of these. I think as @eksperimental said, it makes no sense for translations now as it is, but if we make it full text it will be cluttered with text that's pretty much the same. I guess I would like it better if there was only the bullet, which on mouse over would have the text shown. What do you think?

I'm 馃挴 onboard with this change @nscyclone! Let's do it 馃憤

@gemantzu I considered your approach before and I find it a good option. Once the meaning of the bullet color is known, there is no sense to constantly see repeating description next to it.
Previous changes were merged already so I've proposed a new PR (#1455) that implements aforementioned approach .

I will check it out when I get back from work :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sotojuan picture sotojuan  路  4Comments

jaytheking picture jaytheking  路  3Comments

roberthopman picture roberthopman  路  3Comments

SophieDeBenedetto picture SophieDeBenedetto  路  3Comments

eksperimental picture eksperimental  路  4Comments