Element-android: Stickers in sticker picker aren't cached

Created on 5 Sep 2020  路  3Comments  路  Source: vector-im/element-android

Describe the bug
The stickers (well, I guess images) displayed in the sticker picker aren't cached. Which leads to element android not shwoing any stickers on bad/missing internet connection. And I guess it's redownloading about 10MB of sticker data whenever I want to sent a sticker.

This is using https://github.com/maunium/stickerpicker as a stickerpicker

To Reproduce
Steps to reproduce the behavior:

  1. Have https://github.com/maunium/stickerpicker as a stickerpicker
  2. Open the stickerpicker, wait for all previews to be downloaded
  3. close element android
  4. open stickerpicker again and wait for everything to download again

Expected behavior
I expected that the stickerpicker widget itself and the sticker preview data is cached

Smartphone (please complete the following information):

  • Device: Nexus 5X
  • OS: Android 8.1

Additional context

  • App version 1.0.5-F-Droid
  • Homeserver: bubu1.eu

Most helpful comment

I can confirm there is zero caching. I found the code that disables all caching for widgets and removed it for my personal builds to make stickers viable. Hopefully I'll have a PR to fix that along with a few more sticker issues soon.

All 3 comments

Mmmh, maybe there is some caching. Stickers load faster sometimes. But they definitely don't load at all when you are offline.

I can confirm there is zero caching. I found the code that disables all caching for widgets and removed it for my personal builds to make stickers viable. Hopefully I'll have a PR to fix that along with a few more sticker issues soon.

I can confirm there is zero caching. I found the code that disables all caching for widgets and removed it for my personal builds to make stickers viable. Hopefully I'll have a PR to fix that along with a few more sticker issues soon.

Thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Flam3z picture Flam3z  路  3Comments

TR-SLimey picture TR-SLimey  路  3Comments

jwsp1 picture jwsp1  路  3Comments

bmarty picture bmarty  路  3Comments

Bubu picture Bubu  路  3Comments