Edex-ui: Terminal overflows screen on 1.1.0

[0atman]

New bug on v1.1.0, happened as soon as I upgraded, just now.

System: Linux (Ubuntu 18.04)
Shell: zsh

[GitSquared]

Wow. Does this happen everytime you start edex?

[0atman]

Every time!

[kevinwainczak]

It overflows horizontally as well.

[GitSquared]

Lovely. I'm trying to reproduce the issue but so far everything seems good on my end.

Anyone running from source?

[kevinwainczak]

Yes. I just cloned the repo and ran it ~20 minutes ago on MacOS (Mojava v10.14).

[GitSquared]

@kevinwainczak Would you mind running it from source, opening the command tools (command+shift+i i think?) and running this in the console : window.term.fit() ?

Expected result is that the terminal will scale back to its container.

[kevinwainczak]

@GitSquared I'm getting a result saying that window.term.fit() is not a function. window.term is successfully recognizing the terminal, though.

[GitSquared]

@kevinwainczak Crap, of course. How about window.term[window.currentTerm].fit() ?

[eadwu]

Can confirm on NixOS on master and 1.1.0. Other things I notice are that clicking on a tab other than the main shell more than once (after spawning the shell) causes malformation of the entire terminal window.

Trying to run a command in the terminal afterwards results in a panic/reload dialog.

✖  error     TypeError: Cannot convert undefined or null to object: Uncaught TypeError: Cannot convert undefined or null to object
⬤  debug     at file:///nix/store/a5agbfvapr8qqa7dbsdrw8sm74bxhz93-eDEX-UI-bare-1.1.0/src/_renderer.js 422:39
✖  error     TypeError: Cannot read property 'term' of null: Uncaught TypeError: Cannot read property 'term' of null
⬤  debug     at file:///nix/store/a5agbfvapr8qqa7dbsdrw8sm74bxhz93-eDEX-UI-bare-1.1.0/src/_renderer.js 303:57

Also trying to spawn a tab during the loading process makes it eventually crash with ioctl error (this might be a problem with my build process, fails on electron 2.0.13 as well).

✖  fatal     Error: ioctl(2) failed.
    at UnixTerminal.resize (/nix/store/0d8n97ivx5b1w9a165gws895jvy6c7am-eDEX-UI-bare-1.1.0/src/node_modules/node-pty/lib/unixTerminal.js:213:13)
    at EventEmitter.Terminal.Ipc.on.args (/nix/store/0d8n97ivx5b1w9a165gws895jvy6c7am-eDEX-UI-bare-1.1.0/src/classes/terminal.class.js:312:34)
    at EventEmitter.emit (events.js:187:15)
    at WebContents.<anonymous> (/nix/store/dn245bsxp2hdyz6njwcr4dq7gl3mxvlj-electron-3.0.10/lib/electron/resources/electron.asar/browser/api/web-contents.js:284:13)
    at WebContents.emit (events.js:182:13)

Might be worth truncating the title?
https://i.imgur.com/n05ADtF.png

[GitSquared]

@eadwu Yeah, i got that one under control. Fix on the way.

[kevinwainczak]

@GitSquared Calling the function doesn't fix it, but the function is getting called.

[GitSquared]

@kevinwainczak Damned. This is straight from xterm.js, i don't see why it stopped working.

Thanks for your help.

[0atman]

amazing hustle guys, thank you!

[Cry0lab]

This is happening for me as well, Fedora 28, if that matters.

[GitSquared]

Fix coming tomorrow i'm afraid.

[kingfengji]

same here, windows 10.
But still awesome and badass upgrade, nice to have multiple tabs yo.

[martin-flaregames]

Running into the same issue, using Manjaro / XFCE / bash. Installed from AUR edex-ui (1.1.0-1)

[warsix4]

Windows 10 v1809 same issue. Installed from installer exe.

[GitSquared]

Now i see why i didn't get this issue sooner. For some weird web-engine related reason this bug occurs only on certain themes. Go figure. I'll see if i can find a hack that'll make this work again.

[GitSquared]

@0atman @kevinwainczak @eadwu @Cry0lab @kingfengji @martin-flaregames @warsix4

Thank you all for the reports. Issue has been fixed & i'm releasing v1.1.1 to include this along with the fix for #292 and one for a theme-changer related issue. Original v1.1.0 assets will be overwritten so the broken release can't be downloaded again.

Sorry for the delay!

[kingfengji]

Works for windows here, dude.
Plus: the chalkboard theme supports keywords highlight with different color!
I'm on fire!