Eddiebot: Checkmark for removing the "bad language" embed

[TECHNOFAB11]

Adding a checkmark to be able to dismiss the message would make it possible for the author to remove it upon reading. This would clutter the chat history less.
The next step could be to check if the message which contained bad language was edited and the bad word was removed.
Depending on how many messages are edited every minute this may be a bad idea tho.

Image from Discord:

[github-actions[bot]]

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[Vyvy-vi]

That's a great idea!
We could have the bot react to the message with a ✅ and if the user reacts with that, the embed disappears
OR, we could leave it up to the user and not react with it beforehand(though that might lead to ppl not knowing about this feature)

[BOLT04]

@TECHNOFAB11 removing the message to reduce clutter is a great idea 👍 ! But perhaps we should be cautious with how this is done. If the user doesn't take action and simply reacts with an emoji, resulting in the message going away, this becomes a workaround to the bot's warning.

Also, the user can edit and change its message to use words different from the recommended ones. So I think we should run the Alex bot on the edited string again, instead of just checking if the recommended words replaced the previous flagged word.

Depending on how many messages are edited every minute this may be a bad idea tho.

Sorry, I didn't understand. Could you elaborate on why this would be a bad idea in the scenario you mentioned?

[Vyvy-vi]

Also, the user can edit and change its message to use words different from the recommended ones. So I think we should run the Alex bot on the edited string again, instead of just checking if the recommended words replaced the previous flagged word.

That's a great idea!
I think we could fetch the old content and new content, once a message is edited.
We could run the old content with alex and check in new content has no errors.
Though not sure how we'll keep track of the bot's embeds and edit them

[Vyvy-vi]

perhaps we could use the db to store:

wrong_message_id

embed_message_is

I think the rest of the data can be found using those two

[TECHNOFAB11]

@BOLT04

Sorry, I didn't understand. Could you elaborate on why this would be a bad idea in the scenario you mentioned?

It probably isnt, i just often times forget how powerful (websocket) connections and handling can be :D same reason why i often times think that databases cant handle stuff im planning (they definetely can handle 10x the stuff, i just always forget that or so :D)

[eddiejaoude]

the idea is good, but I do not think the author should be able to react and have the bot response removed, because most people will just remove it without updating their message - we have seen people not update messages most of the time. I like the idea of having the bot recheck after the message is updated, then if so removing the bot response. We could keep this simple and avoid the DB by keeping it in memory - worst case if the bot is restarted / redeployed, the recent bot replies will not get removed. But I don't see this to be an issue, because the bot responses are getting less as people learn and we config the AlexJS more.

[mikeysan]

If we are voting, I am in camp "leave the message and only remove after the offending word is changed" - if that's even a camp to vote for. 😄

[Vyvy-vi]

Could we set up something like an on message update event listener, to see if the message was edited?

[BOLT04]

Could we set up something like an on message update event listener, to see if the message was edited?

@Vyvy-vi Here it is 😃: https://discord.js.org/#/docs/main/stable/class/Client?scrollTo=e-messageUpdate.

Now we have access to the oldMessage and newMessage so the function that handles this event can recheck the new content with Alex. I agree with @eddiejaoude and we can start with a map in memory where the key is the ID of the message that caused the warning, and the value is the message id of the warning (the solution proposed here)