Eddiebot: Tips command should load md files dynamically

Created on 22 Sep 2020  路  11Comments  路  Source: EddieJaoudeCommunity/EddieBot

enhancement

Most helpful comment

yes, that availableTips is way better placed in config 馃槂

All 11 comments

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 馃 . Any questions let us know.

Hi @BhuvaneshHingal 馃槂, thank you for raising this issue.
I think this was done in this PR #254. Can you confirm this is what you meant by dynamically loading the md files? If not, could you provide a description for your request?

Hi @BhuvaneshHingal 馃槂, thank you for raising this issue.
I think this was done in this PR #254. Can you confirm this is what you meant by dynamically loading the md files? If not, could you provide a description for your request?

@BOLT04 Yeah, I guess PR #254 has solved this issue but let's confirm with @eddiejaoude since he wanted an issue number to create a PR.

The issue used to associate the PR was this one #253, but we can wait to see if this issue was resolved then 馃憤

At the moment, we use have a switch statement, I wonder if we can make it more dynamic - maybe it is not required, it was just an idea https://github.com/EddieJaoudeCommunity/EddieBot/blob/develop/src/commandHandlers/tips/tips.ts#L24

ah got it 馃憤, that is a great idea. Completely different from that PR then, my mistake 馃槄
Right now I can think of one implementation perhaps:

const availableTips = ['opensource', 'github']
if (availableTips.includes(subject)
    return createTip(embed);
return embed.setTitle('Tips').setDescription('Sorry ...');

But it can be more dynamic to the point that when someone contributes with a new file for like Tailwind tips, we don't need to change this piece of code to support those tips on the tips command

That looks better 馃憤 . Yeah the idea is to make it easier for people to add md files without changing code - maybe having it all in the config?

if (config.availableTips.includes(subject))

yes, that availableTips is way better placed in config 馃槂

Stale issue message

Stalebot we still want this 馃

Stale issue message

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RaisinTen picture RaisinTen  路  10Comments

adityaraute picture adityaraute  路  18Comments

RaisinTen picture RaisinTen  路  24Comments

GoluffyxD picture GoluffyxD  路  12Comments

AllanRegush picture AllanRegush  路  18Comments